Conversation
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughTwo targeted changes: eager-loading budgets in a governance handler DB query for virtual-key provider configs, and fixing Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Confidence Score: 5/5Safe to merge — both changes are minimal, targeted bug fixes with no regressions introduced. The Go change correctly adds No files require special attention.
|
| Filename | Overview |
|---|---|
| transports/bifrost-http/handlers/governance.go | Adds Preload("Budgets") to the GORM query fetching existing provider configs during virtual key updates, so that the budget reconciliation map is populated correctly and avoids duplicate budget creation. |
| ui/components/prompts/fragments/settingsPanel.tsx | Passes the unfiltered prop to ModelMultiselect so the settings panel shows all available models, and fixes indentation of the vks prop. |
Reviews (2): Last reviewed commit: "fix: provider level multiline budget dup..." | Re-trigger Greptile
Merge activity
|
The base branch was changed.
… true param for ModelMultiselect
a25bc2f to
908f714
Compare

Summary
Fixes virtual key provider config updates to stop duplication of budgets on
provider level by ensuring budget data is properly loaded and enables unfiltered
model display.
Changes
Preload("Budgets")to the database query when fetching existingprovider configs during virtual key updates to ensure budget relationships are
loaded to prevent duplication of budgets on provider level
unfilteredprop toModelMultiselectcomponent in the settings panelto show all available models
vksprop in the ModelMultiselect componentType of change
Affected areas
How to test
Test the virtual key update functionality to ensure budget data is properly
preserved:
Verify that updating virtual key provider configurations maintains budget
associations and that the model selector shows all available models without
filtering.
Screenshots/Recordings
N/A
Breaking changes
Related issues
N/A
Security considerations
No security implications - this change only affects data loading relationships
and UI filtering behavior.
Checklist
docs/contributing/README.mdand followed the guidelines