Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a comprehensive per-user OAuth consent flow for MCP (Model Context Protocol) servers. This adds a multi-step authentication process where users can authenticate with upstream services (like Notion, GitHub) through a web interface before using MCP tools, replacing the previous runtime-only authentication approach.
Changes
TablePerUserOAuthPendingFlowto track OAuth state through multi-step consent screensKey design decisions:
flow:<flowID>) temporarily store upstream tokens during consentType of change
Affected areas
How to test
per_user_oauthauthenticationTest the consent flow:
/mcpendpoint - should redirect to OAuth authorizationScreenshots/Recordings
The consent flow includes:
Breaking changes
This is additive functionality that enhances the existing per-user OAuth system without breaking existing integrations.
Related issues
Enhances MCP per-user OAuth capabilities by providing a user-friendly consent interface instead of requiring runtime authentication prompts.
Security considerations
Checklist
docs/contributing/README.mdand followed the guidelines