ci: trim whitespace from R2 secrets and improve debug logging#189
Merged
Pratham-Mishra04 merged 1 commit intomainfrom Jul 23, 2025
Merged
ci: trim whitespace from R2 secrets and improve debug logging#189Pratham-Mishra04 merged 1 commit intomainfrom
Pratham-Mishra04 merged 1 commit intomainfrom
Conversation
Contributor
Summary by CodeRabbit
WalkthroughThe changes introduce stricter handling and validation of environment variables used in the build upload process. In the workflow file, whitespace is explicitly trimmed from relevant environment variables before use. The upload script now provides detailed debug output, masking variable values, checking for whitespace or newlines, and exiting immediately if a required variable is missing. Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant upload-builds.mjs
GitHub Actions->>GitHub Actions: Trim whitespace from R2 env vars
GitHub Actions->>upload-builds.mjs: Run upload script with cleaned env vars
upload-builds.mjs->>upload-builds.mjs: Validate each env var
alt Variable missing
upload-builds.mjs->>GitHub Actions: Log missing variable, exit
else Variable present
upload-builds.mjs->>GitHub Actions: Log masked value, check for whitespace/newlines
upload-builds.mjs->>GitHub Actions: Warn if whitespace/newlines found
upload-builds.mjs->>GitHub Actions: Continue process
end
Estimated code review effort2 (~15 minutes) Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🧠 Learnings (2)📓 Common learningsci/scripts/upload-builds.mjs (2)Learnt from: Pratham-Mishra04 Learnt from: Pratham-Mishra04 🧰 Additional context used🧠 Learnings (2)📓 Common learningsci/scripts/upload-builds.mjs (2)Learnt from: Pratham-Mishra04 Learnt from: Pratham-Mishra04 🔇 Additional comments (2)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
SamstyleGhost
approved these changes
Jul 23, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
akshaydeo
pushed a commit
that referenced
this pull request
Nov 17, 2025
# Trim whitespace from R2 secrets and improve environment variable validation This PR addresses an issue with R2 credentials in our release workflow by: 1. Adding whitespace trimming for R2 environment variables in the transports-release workflow 2. Enhancing the upload-builds.mjs script with better environment variable validation: - Displays the length of each credential - Shows first/last few characters of credentials (partially masked) - Detects and warns about common issues like newlines or trailing spaces These changes will help prevent authentication failures caused by invisible whitespace characters in secrets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trim whitespace from R2 secrets and improve environment variable validation
This PR addresses an issue with R2 credentials in our release workflow by:
These changes will help prevent authentication failures caused by invisible whitespace characters in secrets.