feat: add environment variable support for MCP connection strings#131
Merged
Pratham-Mishra04 merged 1 commit intomainfrom Jun 26, 2025
Merged
Conversation
Contributor
Summary by CodeRabbit
WalkthroughA new method, Changes
Sequence Diagram(s)sequenceDiagram
participant Main
participant Config
participant Env
Main->>Config: ReadKeys()
Main->>Config: ReadMCPKeys()
Config->>Env: Lookup env variables for MCP clients
Env-->>Config: Return values or errors
Config-->>Main: Return success or error
Main->>Main: Log warning if error
Poem
✨ Finishing Touches
🧪 Generate Unit Tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
akshaydeo
approved these changes
Jun 26, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
transports/bifrost-http/lib/config.go(2 hunks)transports/bifrost-http/main.go(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
transports/bifrost-http/lib/config.go (1)
core/schemas/mcp.go (1)
MCPConfig(6-9)
🔇 Additional comments (2)
transports/bifrost-http/lib/config.go (1)
7-7: LGTM - Import addition is appropriate.The
fmtimport is correctly added to support the error formatting in the newReadMCPKeys()method.transports/bifrost-http/main.go (1)
158-160: LGTM - Clean integration following established patterns.The integration of
ReadMCPKeys()is well-implemented:
- Correctly placed after
account.ReadKeys()- Uses appropriate warning-level logging for non-fatal errors
- Allows the application to continue running even if MCP environment variables are missing
- Follows the same error handling pattern as the account key processing above
akshaydeo
deleted the
06-26-chore_added_read_envs_in_mcp_config_for_transports
branch
akshaydeo
pushed a commit
that referenced
this pull request
Nov 17, 2025
# Add environment variable support for MCP connection strings This PR adds functionality to read environment variables for MCP connection strings in the Bifrost HTTP transport. The implementation: - Adds a new `ReadMCPKeys()` method to the `BifrostHTTPConfig` struct - Allows connection strings prefixed with "env." to be replaced with values from environment variables - Processes each MCP client configuration and updates connection strings accordingly - Returns appropriate error messages when required environment variables are missing - Integrates the new functionality in the main application flow This enhancement provides a more secure way to handle sensitive connection information by keeping it out of configuration files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add environment variable support for MCP connection strings
This PR adds functionality to read environment variables for MCP connection strings in the Bifrost HTTP transport. The implementation:
ReadMCPKeys()method to theBifrostHTTPConfigstructThis enhancement provides a more secure way to handle sensitive connection information by keeping it out of configuration files.