Fix issue where setLogger did not adhere to the LoggerAwareInterface and change minimum PHP requirement to PHP 8 #286
Conversation
|
Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @Rocksheep. |
|
The CLA is signed! |
|
@cla-bot check Thanks for the PR @Rocksheep and welcome to the community! |
|
The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings! |
|
I have updated the minimum PHP version to 8.0 for now and PHP CS fixer has been updated as well. It was the only dependency I found that really needed an update. |
Rocksheep
changed the title
|
So, since php 7.4 is end of life. Should a new release be made to include this change? |
|
Yes, since we plan to release a new major version, we can ditch PHP 7.4 support. |
* Use PHP 8.0 * Bump actions/checkout to v3 * Run composer update * Bump php-cs-fixer for PHP 8.0 support * Fixing failing tests due to new duplicity checks in Mautic Co-authored-by: John Linhart <[email protected]>
|
Hey there, any news regarding this PR? Thanks |
|
To use the fork, just add this to your composer.json |
|
As far as I can tell, nobody has tested or reviewed this PR, and it won't be merged until that happens. Maybe you can join us with our Open Source Friday sprints in #t-product on slack, that's a great way to encourage people to test PRs. Testing instructions are also super helpful. More on testing: https://contribute.mautic.org/contributing-to-mautic/tester On the requirements to merge: https://contribute.mautic.org/community-structure/governance/code-governance |
Fix for Deprecated : strlen(): Passing null to parameter mautic#1 ($string) of type string is deprecated in api-library/lib/Auth/OAuth.php on - line 388 - line 395 - line 637
Co-authored-by: John Linhart <[email protected]>
# Conflicts: # composer.lock
|
Alright, the branch has been synced and the conflicts have been resolved |
|
@all-contributors please add @Rocksheep for code |
|
I've put up a pull request to add @Rocksheep! 🎉 |
|
@all-contributors please add @PierreAmmeloot for userTesting |
|
I've put up a pull request to add @PierreAmmeloot! 🎉 |
|
Although the CI might need more work after the CS Fixer update... |
|
I'll fix the CS script and the resulting issues. So give me a few minutes and then it should all work! It's mostly some untyped |
|
All the style changes have been fixed and the action should be configured correctly now. |
Codecov Report
@@ Coverage Diff @@
## main #286 +/- ##
============================================
+ Coverage 49.94% 52.05% +2.10%
+ Complexity 408 407 -1
============================================
Files 30 30
Lines 973 1093 +120
============================================
+ Hits 486 569 +83
- Misses 487 524 +37
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The setLogger method on the Api class never adhered to the setLogger method of LoggerAwareInterface. This is causing issues when using a newer version of the psr/log libraries which uses return types.
While testing I noticed that there was a variable being used that was not declared, so I swapped it out with false. Let me know if this is alright with you guys.
This PR fixes #273