-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PHP 8.0 in CI due to failing runs #289
Conversation
Ok so the good news is that CI runs again, but there's a few failing tests (one of them being a |
Thank you Dennis! I'll try to find some time to look into the failing tests this week and merge this. We plan to release new major version of this library so this is a good start. |
I fixed the failing tests in this repo and one more was failing due to PHP 8 strictness on Mautic's side. Here is the fix for that: mautic/mautic#11873 |
Codecov Report
@@ Coverage Diff @@
## main #289 +/- ##
============================================
+ Coverage 49.94% 51.58% +1.63%
Complexity 408 408
============================================
Files 30 30
Lines 973 1103 +130
============================================
+ Hits 486 569 +83
- Misses 487 534 +47
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks @escopecz!! Let's merge this 🔥 |
I keep getting these daily emails that CI is failing for this repo. Here's a failing run: https://github.com/mautic/api-library/actions/runs/3922881304
Things are failing because PHP 8.0 is now required. This PR updates PHP to that version, which hopefully should fix things.