Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about DDEV first-run experience to README #236

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Conversation

dennisameling
Copy link
Member

This probably can use some better wording - calling the grammar police AKA @RCheesley for doing some checks! 😊

Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just a few small suggestions! 👮‍♀️

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dennisameling
Copy link
Member Author

Thanks for the feedback! Will merge as soon as #235 is merged

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@78ddcb8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage        ?   51.45%           
  Complexity      ?      406           
=======================================
  Files           ?       30           
  Lines           ?     1028           
  Branches        ?        0           
=======================================
  Hits            ?      529           
  Misses          ?      499           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ddcb8...6d0716a. Read the comment docs.

@dennisameling dennisameling merged commit 8d0aa0e into main Feb 17, 2021
@dennisameling dennisameling deleted the update-readme branch February 17, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants