Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DDEV first-run experience ✨ #235

Merged
merged 5 commits into from
Feb 17, 2021

Conversation

dennisameling
Copy link
Member

How to test:

  • Checkout this branch locally
  • Run ddev start
  • The first-run experience should start 🚀 try answering "yes" so that a local Mautic instance is created

Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is super cool! Followed the instructions, Mautic was set up by DDEV automagically in /mautic .... total game changer!

🚀 😍 🎉

@dennisameling
Copy link
Member Author

Note to self: add some info about this first-run experience to the README

@dennisameling
Copy link
Member Author

Closing and re-opening now that mautic/mautic#9667 is merged 🚀 tests should pass now

@RCheesley
Copy link
Member

Seems that there are still some tests failing @dennisameling :(

@dennisameling dennisameling force-pushed the add-ddev-first-start-config branch from dc621ed to 34b9e91 Compare February 17, 2021 15:37
@codecov-io
Copy link

codecov-io commented Feb 17, 2021

Codecov Report

Merging #235 (66fa38d) into main (aa40418) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #235   +/-   ##
=========================================
  Coverage     51.45%   51.45%           
  Complexity      406      406           
=========================================
  Files            30       30           
  Lines          1028     1028           
=========================================
  Hits            529      529           
  Misses          499      499           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa40418...66fa38d. Read the comment docs.

@dennisameling dennisameling merged commit 12ba52f into mautic:main Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants