Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(): reviewType and new prompt construction method #95

Merged
merged 14 commits into from
Aug 7, 2023
Merged

feat(): reviewType and new prompt construction method #95

merged 14 commits into from
Aug 7, 2023

Conversation

mattzcarey
Copy link
Owner

@mattzcarey mattzcarey commented Aug 5, 2023 •
edited
Loading

also fixes json bug

closes #80 #79

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023 •
edited
Loading

Risk Level 2 - /home/runner/work/code-review-gpt/code-review-gpt/src/args.ts

The getYargs function has been updated to include new options for the command line interface. The changes seem to be well implemented, but it's important to ensure that the new options are properly documented and tested.

Risk Level 3 - /home/runner/work/code-review-gpt/code-review-gpt/src/common/model/AIModel.ts

The callModelJSON function has been updated to include error handling and logging. This is a good practice, but it's important to ensure that the error handling doesn't interfere with the normal flow of the application.

Risk Level 3 - /home/runner/work/code-review-gpt/code-review-gpt/src/common/utils/parseAttributes.ts

The new function parseAttributes has been added. This function seems to be complex and it's important to ensure that it's properly tested.

📝🔍🧪

Powered by Code Review GPT

@mattzcarey mattzcarey changed the title wip(): reviewType and new prompt construction method feat(): reviewType and new prompt construction method Aug 6, 2023
@mattzcarey mattzcarey marked this pull request as ready for review August 6, 2023 16:16
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023 •
edited
Loading

Test results summary:

✅ [PASS] - Test case: Bad variable name
✅ [PASS] - Test case: Exposed secret
✅ [PASS] - Test case: Too many nested loops
✅ [PASS] - Test case: Unawaited Promise

SUMMARY: ✅ PASS: 4 - ⚠️ WARN: 0 - ❌ FAIL: 0

Tests Powered by Code Review GPT

@mattzcarey mattzcarey force-pushed the feat/new-prompt-construction branch from 8741691 to a1adcc8 Compare August 6, 2023 18:19
@mattzcarey mattzcarey force-pushed the feat/new-prompt-construction branch from a1adcc8 to d371966 Compare August 6, 2023 18:30
@mattzcarey mattzcarey linked an issue Aug 6, 2023 that may be closed by this pull request
[Bug] Occasional Undetermined String Error in callModelJSON() #79
Closed
gowoons
gowoons reviewed Aug 7, 2023
View reviewed changes
src/args.ts Outdated Show resolved Hide resolved
src/common/utils/parseAndDecodeAttributes.ts Outdated Show resolved Hide resolved
lizacullis
lizacullis approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@lizacullis lizacullis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some seriously cool stuff! Very nice!

src/common/utils/parseAndDecodeAttributes.ts Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super interesting! Is this what solved the json bug?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!!

@mattzcarey mattzcarey merged commit 613d3e8 into main Aug 7, 2023
@mattzcarey mattzcarey deleted the feat/new-prompt-construction branch August 7, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gowoons gowoons gowoons left review comments

@lizacullis lizacullis lizacullis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mattzcarey @gowoons @lizacullis