Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add welcome email to add user lambda #208

Merged
merged 7 commits into from
Aug 23, 2023

Conversation

SEBRATHEZEBRA
Copy link
Contributor

No description provided.

@SEBRATHEZEBRA SEBRATHEZEBRA linked an issue Aug 22, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023


👍👎🤔


Powered by Code Review GPT

@SEBRATHEZEBRA SEBRATHEZEBRA marked this pull request as ready for review August 23, 2023 10:35
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

Test results summary:

✅ [PASS] - Test case: Bad variable name
❌ [FAIL] - Test case: Exposed secret
✅ [PASS] - Test case: Too many nested loops
⚠️ [WARN] - Test case: Unawaited Promise

SUMMARY: ✅ PASS: 2 - ⚠️ WARN: 1 - ❌ FAIL: 1


Tests Powered by Code Review GPT

jest.config.js Outdated Show resolved Hide resolved
services/tests/EmailWorkerInteg.test.ts Outdated Show resolved Hide resolved
services/tests/jest.config.js Outdated Show resolved Hide resolved
services/web-app/README.md Outdated Show resolved Hide resolved
},
body: JSON.stringify({
"to": {"email": email, "name": name },
"from": { "email": "[email protected]", "name": "Orion Tools" },
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to have it come from [email protected]. Name: 'Matt from Orion Tools'

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change this

services/web-app/sst.config.ts Outdated Show resolved Hide resolved
mattzcarey
mattzcarey previously approved these changes Aug 23, 2023
@mattzcarey mattzcarey dismissed their stale review August 23, 2023 13:57

tests failing

@SEBRATHEZEBRA SEBRATHEZEBRA merged commit c5c3f48 into main Aug 23, 2023
@SEBRATHEZEBRA SEBRATHEZEBRA deleted the feat/lambda-welcome-email branch August 23, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Email Service]: AAaddUser Lambda I send a welcome email
2 participants