Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Email Service]: AAaddUser Lambda I send a welcome email #157

Closed
mattzcarey opened this issue Aug 11, 2023 · 2 comments · Fixed by #208
Closed

[Email Service]: AAaddUser Lambda I send a welcome email #157

mattzcarey opened this issue Aug 11, 2023 · 2 comments · Fixed by #208
Assignees

Comments

@mattzcarey
Copy link
Owner

mattzcarey commented Aug 11, 2023

Description

We are going to send users emails when they sign up for the platform. This allows us to get them to sign up for the slack community. Also gives us more visibility in their inbox.

Dependencies

We will have to add records to the DNS. <- needs to be done before

Validation steps

Sign up and get a screenshot email

Tech steps

We are going to be really cheeky and use a free service which is not widely talked about.

Cloudflare offer free transactional emails from their workers as result of a partnership with MailChannels.
We are going to use a deployed cloudflare worker (kinda like lambda) which will send out emails.
Free tier is huge so we should be fine. Whereas SES you pay for each email.

Steps:
Have a look at the readme for repo 'mattzcarey/worker-email'
Ask Matt for the API key token for the worker. This will be written to SSM.
Ask Matt for the url of the worker. put it in the env variables of the addUser lambda

AddUser lambda should hit the worker endpoint /api/email before it adds the email to the usersDB.

This email should be super basic.
Thanks for signing up for Orion tools. We aim to make the best AI powered dev tools. We hope you enjoy using our code review product. Here is a link to the repo, give it a star. Here is a link to our slack community.
Next steps... Install the github app etc

Tests?

In services make a new service tests. this should include all integ tests.
set up jest in this directory.

Edit to add an include attribute to the top-level jest.config to only include tests in src.

Write a test to ensure that this email still works over time. Basically just checking the 3rd party. Hit the endpoint directly and check you receive a 200.

Add a CI step to run integ tests on PR.

@mattzcarey
Copy link
Owner Author

Future we will look to have 2 mails.

  1. for signing up
  2. after the first week. this will be different if the user has used the tool or if they have not used the tool yet.

@mattzcarey mattzcarey moved this from Backlog to TR Done in Code Review GPT Roadmap Aug 11, 2023
@ChristianN1234 ChristianN1234 moved this from TR Done to Daily goals in Code Review GPT Roadmap Aug 15, 2023
@SEBRATHEZEBRA SEBRATHEZEBRA moved this from Daily goals to In Progress in Code Review GPT Roadmap Aug 21, 2023
@SEBRATHEZEBRA SEBRATHEZEBRA linked a pull request Aug 22, 2023 that will close this issue
@SEBRATHEZEBRA
Copy link
Contributor

Image

@SEBRATHEZEBRA SEBRATHEZEBRA moved this from In Progress to Code Review in Code Review GPT Roadmap Aug 23, 2023
@SEBRATHEZEBRA SEBRATHEZEBRA moved this from Code Review to Functional Review in Code Review GPT Roadmap Aug 23, 2023
@mattzcarey mattzcarey moved this from Functional Review to To Validate in Code Review GPT Roadmap Aug 24, 2023
@aiden-walton aiden-walton moved this from To Validate to Done in Code Review GPT Roadmap Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants