fix(e2e): dispatch mobile PR E2E against default-branch workflow - #95
Closed
yasserfaraazkhan wants to merge 1 commit into
Closed
fix(e2e): dispatch mobile PR E2E against default-branch workflow#95yasserfaraazkhan wants to merge 1 commit into
yasserfaraazkhan wants to merge 1 commit into
Conversation
Release cherry-pick heads often lack five-server workflow inputs, so dispatching with ref=PR head returns 422. Use ref=main for mobile PR dispatches (MOBILE_VERSION stays the PR SHA) and cancel in-flight runs by run-name "E2E PR <n>" instead of head_branch. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@yasserfaraazkhan: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsI understand the commands that are listed here |
3 tasks
📝 WalkthroughWalkthroughMobile E2E dispatches now use the ChangesMobile E2E workflow handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Matterwick
participant GitHubAPI
participant MobileWorkflow
Matterwick->>GitHubAPI: Dispatch mobile workflow from main
Matterwick->>GitHubAPI: Send version_name, pr_number, and run_type
GitHubAPI->>MobileWorkflow: Start E2E PR workflow
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@server/e2e_tests.go`:
- Around line 1722-1734: Update the mobile workflow matching in the loop using
prTitlePrefix so PR numbers match exactly rather than sharing a prefix; require
the complete display title or its valid separator. Preserve desktop branch
matching, and add coverage for PR 1 not matching PR 10.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 54b9cf1d-60de-4613-9006-5cd7400489db
📒 Files selected for processing (2)
server/e2e_dryrun_test.goserver/e2e_tests.go
Comment on lines
+1722
to
+1734
| // Mobile PR runs are dispatched with ref=main and run-name "E2E PR <n>", so | ||
| // match display_title (not head_branch == pr.Ref). Desktop still matches branch. | ||
| prTitlePrefix := fmt.Sprintf("E2E PR %d", pr.Number) | ||
| cancelCount := 0 | ||
| for _, run := range workflowRuns.WorkflowRuns { | ||
| // Check if this run is for the PR's branch | ||
| if run.HeadBranch == pr.Ref && run.Status == "in_progress" { | ||
| cancelURL := fmt.Sprintf("/repos/%s/%s/actions/runs/%d/cancel", | ||
| pr.RepoOwner, pr.RepoName, run.ID) | ||
| if run.Status != "in_progress" { | ||
| continue | ||
| } | ||
| matches := run.HeadBranch == pr.Ref | ||
| if strings.Contains(pr.RepoName, "mobile") { | ||
| matches = strings.HasPrefix(run.DisplayTitle, prTitlePrefix) | ||
| } | ||
| if !matches { |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Prevent cancellation of runs for a different PR.
strings.HasPrefix(run.DisplayTitle, "E2E PR 1") also matches "E2E PR 10". The cancellation can stop an in-progress workflow for another PR.
Match the complete title, or require the title separator that follows the PR number. Add a case for PR 1 and PR 10.
Proposed fix
prTitlePrefix := fmt.Sprintf("E2E PR %d", pr.Number)
cancelCount := 0
for _, run := range workflowRuns.WorkflowRuns {
if run.Status != "in_progress" {
continue
}
matches := run.HeadBranch == pr.Ref
if strings.Contains(pr.RepoName, "mobile") {
- matches = strings.HasPrefix(run.DisplayTitle, prTitlePrefix)
+ matches = run.DisplayTitle == prTitlePrefix ||
+ strings.HasPrefix(run.DisplayTitle, prTitlePrefix+" ")
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| // Mobile PR runs are dispatched with ref=main and run-name "E2E PR <n>", so | |
| // match display_title (not head_branch == pr.Ref). Desktop still matches branch. | |
| prTitlePrefix := fmt.Sprintf("E2E PR %d", pr.Number) | |
| cancelCount := 0 | |
| for _, run := range workflowRuns.WorkflowRuns { | |
| // Check if this run is for the PR's branch | |
| if run.HeadBranch == pr.Ref && run.Status == "in_progress" { | |
| cancelURL := fmt.Sprintf("/repos/%s/%s/actions/runs/%d/cancel", | |
| pr.RepoOwner, pr.RepoName, run.ID) | |
| if run.Status != "in_progress" { | |
| continue | |
| } | |
| matches := run.HeadBranch == pr.Ref | |
| if strings.Contains(pr.RepoName, "mobile") { | |
| matches = strings.HasPrefix(run.DisplayTitle, prTitlePrefix) | |
| } | |
| if !matches { | |
| // Mobile PR runs are dispatched with ref=main and run-name "E2E PR <n>", so | |
| // match display_title (not head_branch == pr.Ref). Desktop still matches branch. | |
| prTitlePrefix := fmt.Sprintf("E2E PR %d", pr.Number) | |
| cancelCount := 0 | |
| for _, run := range workflowRuns.WorkflowRuns { | |
| if run.Status != "in_progress" { | |
| continue | |
| } | |
| matches := run.HeadBranch == pr.Ref | |
| if strings.Contains(pr.RepoName, "mobile") { | |
| matches = run.DisplayTitle == prTitlePrefix || | |
| strings.HasPrefix(run.DisplayTitle, prTitlePrefix+" ") | |
| } | |
| if !matches { |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@server/e2e_tests.go` around lines 1722 - 1734, Update the mobile workflow
matching in the loop using prTitlePrefix so PR numbers match exactly rather than
sharing a prefix; require the complete display title or its valid separator.
Preserve desktop branch matching, and add coverage for PR 1 not matching PR 10.
Contributor
Author
|
Closing: no Matterwick change needed — release cherry-pick PRs are normal PRs; dispatch stays |
yasserfaraazkhan
deleted the
matterwick/mobile-e2e-dispatch-from-default
branch
August 4, 2026 09:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed: release-* PRs should behave like any other PR (dispatch with
ref=<PR head>). No Matterwick special-case. The fix is backporting currente2e-detox-pr.yml/ E2E CI onto the release line so the head accepts five-server inputs.