Skip to content

docs(e2e): manual E2E/Run for release cherry-pick PRs - #10003

Closed
yasserfaraazkhan wants to merge 1 commit into
mainfrom
docs/e2e-manual-release-cherry-pick
Closed

docs(e2e): manual E2E/Run for release cherry-pick PRs#10003
yasserfaraazkhan wants to merge 1 commit into
mainfrom
docs/e2e-manual-release-cherry-pick

Conversation

@yasserfaraazkhan

@yasserfaraazkhan yasserfaraazkhan commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Decision: Do not auto-apply E2E/Run for cherry-pick PRs (or other PRs targeting release-*). E2E stays opt-in via a manual E2E/Run label.
  • Auto E2E remains for PRs against main and for release E2E on build-release-* pushes (existing Matterwick flows).
  • Rationale: each mobile E2E holds five cloud installs; auto-running on every release cherry-pick batch overloads provisioning (409s / failed dispatches).
  • Release-* PRs are normal PRs for Matterwick (ref=<PR head>). For manual E2E/Run to succeed, the release line must have current E2E CI (five-server inputs + e2e-test/* statuses) — tracked as a separate release backport, not a Matterwick special-case.
  • We are investigating cloud provisioning improvements (retries, shorter PR server TTL, clearer failure alerts) for high create-demand.

Test plan

  • Confirm cherry-pick / release-* PRs do not get E2E/Run on open/sync
  • Confirm manual E2E/Run still triggers Matterwick the same way as on main PRs
  • Confirm main PRs still auto-label as today

Auto E2E/Run stays main-only; release-* / AutomatedCherryPick PRs remain
opt-in to avoid five-server cloud overload on every cherry-pick batch.

Co-authored-by: Cursor <cursoragent@cursor.com>
@mm-cloud-bot

Copy link
Copy Markdown

@yasserfaraazkhan: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

I understand the commands that are listed here

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The change documents branch-specific E2E trigger ownership and execution rules. It also adds stable run names and changes concurrency groups to use the pull request number or tested commit SHA.

Changes

E2E trigger and workflow execution

Layer / File(s) Summary
Run naming and concurrency grouping
.github/workflows/e2e-detox-pr.yml
The workflow documents dispatch and commit selection rules. Run names use the pull request number or tested mobile version. Concurrency groups use the pull request number or MOBILE_VERSION.
Branch-specific trigger policy
.github/workflows/e2e-label-manager.yml, detox/CLAUDE.md
Documentation limits automatic E2E/Run labelling to pull requests targeting main. Release and other non-main pull requests require manual opt-in. The documentation records five-installation provisioning limits and release-branch dispatch behaviour.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the documented manual E2E/Run behaviour for release cherry-pick pull requests.
Description check ✅ Passed The description directly explains the E2E labelling decision, rationale, affected workflows, and test plan.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/e2e-manual-release-cherry-pick

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Coverage Comparison Report

Generated on August 04, 2026 at 09:35:01 UTC

+-----------------+------------+------------+-----------+
| Metric          | Main       | This PR    | Diff      |
+-----------------+------------+------------+-----------+
| Lines           |     88.15% |     88.15% |     0.00% |
| Statements      |     88.02% |     88.02% |     0.00% |
| Branches        |     76.96% |     76.96% |     0.00% |
| Functions       |     87.48% |     87.48% |     0.00% |
+-----------------+------------+------------+-----------+
| Total           |     85.15% |     85.15% |     0.00% |
+-----------------+------------+------------+-----------+

@mattermost-build mattermost-build added the E2E/Run Triggers E2E tests on both iOS and Android via Matterwick label Aug 4, 2026
@yasserfaraazkhan yasserfaraazkhan changed the title docs(e2e): manual E2E/Run for release cherry-pick PRs docs+fix(e2e): manual E2E/Run for release cherry-picks Aug 4, 2026
@yasserfaraazkhan yasserfaraazkhan changed the title docs+fix(e2e): manual E2E/Run for release cherry-picks docs(e2e): manual E2E/Run for release cherry-pick PRs Aug 4, 2026
@yasserfaraazkhan
yasserfaraazkhan force-pushed the docs/e2e-manual-release-cherry-pick branch from cf2dcfa to a9d992c Compare August 4, 2026 09:25
@mattermost-build mattermost-build added E2E/Run Triggers E2E tests on both iOS and Android via Matterwick and removed E2E/Run Triggers E2E tests on both iOS and Android via Matterwick labels Aug 4, 2026
@yasserfaraazkhan yasserfaraazkhan added the E2E/Override Skip Running E2E tests label Aug 4, 2026
@github-actions github-actions Bot removed the E2E/Run Triggers E2E tests on both iOS and Android via Matterwick label Aug 4, 2026
@yasserfaraazkhan
yasserfaraazkhan deleted the docs/e2e-manual-release-cherry-pick branch August 4, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants