Skip to content

MM-3943 : Migrate to go-i18n 2.X#21327

Closed
KuSh wants to merge 20 commits intomattermost:masterfrom
KuSh:GH-5267
Closed

MM-3943 : Migrate to go-i18n 2.X#21327
KuSh wants to merge 20 commits intomattermost:masterfrom
KuSh:GH-5267

Conversation

@KuSh
Copy link
Copy Markdown
Contributor

@KuSh KuSh commented Oct 10, 2022 •
edited
Loading

Summary

Migrate to go-i18n 2.X to allow context-specific translations

Includes modifications to mmgotool (available in mattermost/mattermost-utilities#68 before the switch to monorepo)

Previously the tool seemed to ignore space only (i.e. " ") translations but that didn't seem right so I've changed the behavior. I've also updated the json format to use 2 space indentation to reflect current json format used in mattermost-server

Ticket Link

Fixes #5267
Fixes https://mattermost.atlassian.net/browse/MM-3943

Release Note

Migrated to go-i18n 2.X

@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 10, 2022
@mattermod
Copy link
Copy Markdown
Collaborator

mattermod commented Oct 10, 2022

Hello @KuSh,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@KuSh KuSh changed the title MM-3943: Migrate to go-i18n 2.X [MM-3943] Migrate to go-i18n 2.X Oct 10, 2022
@KuSh KuSh changed the title [MM-3943] Migrate to go-i18n 2.X MM-3943 : Migrate to go-i18n 2.X Oct 13, 2022
@esethna esethna requested review from laneycs and removed request for esethna October 18, 2022 19:55
@esethna
Copy link
Copy Markdown
Contributor

esethna commented Oct 18, 2022

Re-assigning to @laneycs's team as per AORs

@KuSh KuSh force-pushed the GH-5267 branch 2 times, most recently from 51bffd8 to 1dd3414 Compare November 1, 2022 14:51
@KuSh

This comment was marked as outdated.

Sign in to view
@mattermod
Copy link
Copy Markdown
Collaborator

mattermod commented Nov 22, 2022

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@KuSh
Copy link
Copy Markdown
Contributor Author

KuSh commented Nov 22, 2022 •
edited
Loading

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

It's not stale on my side. I'm just waiting for a review by @gabrieljackson and @laneycs

laneycs
laneycs previously approved these changes Dec 7, 2022
View reviewed changes
@KuSh
Copy link
Copy Markdown
Contributor Author

KuSh commented Dec 12, 2022 •
edited
Loading

Hi @isacikgoz, is there someone else than @gabrieljackson that can review this PR ? It seems to have fallen off its radar

@KuSh KuSh mentioned this pull request Dec 29, 2022
Closed
@KuSh

This comment was marked as outdated.

Sign in to view
KuSh and others added 16 commits October 26, 2023 01:53
@KuSh
Migrate to go-i18n v2.X
f340f55 
Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
@KuSh
fix bad usage of i18n.TDefault
991a38c 
Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
@KuSh
Remove last usage of TDefault
92cdc4a 
Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
@KuSh
Fix tests
b1fd80b 
Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
@KuSh
i18n: Remove locales map as we can rely on bundle internals
8f5db90 
Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
@KuSh
Factorize bundle creation and fix variable shadowing
2bd949b 
Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
@KuSh
fix: don't panic if translations have not been loaded
1a3ce5e 
Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
@KuSh
mmgotool/i18n: Update mmgotool to handle go-i18n 2.X migration
4a5327e 
Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
@KuSh
mmgotool/i18n: Write json file even if there isn't empty translations…
32209a5 
… to cleanup empty plural forms

Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
@KuSh
mmgotool/i18n: Fix clean and extract commands
863c16b 
Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
@KuSh
chore: Upgrade precheck prerequisites to match required versions in p…
6e5c505 
…ackage.json
@isacikgoz @KuSh
server/public/shared/i18n/i18n_test.go: fix test files
952e839
@isacikgoz @KuSh
make tests pass
ef17b8b
@KuSh
Explicitly use latest go-i18n v2 version in server/public
0ef3a13 
Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
@KuSh
fix: Handle temporary regression in latest versions of go-i18n v2
14f206d 
Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
@KuSh
Upgrade go-i18n v2 to v2.2.2
eb0d4c8 
Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
@KuSh
Tidy mmgotool modules
cc411dd 
Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
@hanzei hanzei added the 2: Dev Review Requires review by a developer label Nov 23, 2023
@Willyfrog Willyfrog removed their request for review September 19, 2024 09:52
@KuSh KuSh force-pushed the GH-5267 branch 2 times, most recently from 4b552f0 to 4d35b40 Compare October 6, 2024 22:33
@KuSh
Merge remote-tracking branch 'upstream/master' into mattermostGH-5267
fde8cc3 
Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
@KuSh
Copy link
Copy Markdown
Contributor Author

KuSh commented Oct 15, 2024

I've rebased the PR and I'm willing to maintain it if it's still valuable to you

bep pushed a commit to gohugoio/go-i18n that referenced this pull request Oct 18, 2025
@KuSh @bep
Fix Localize regression with empty default message (nicksnyder#305)
0d56550 
Behavior has changed with nicksnyder#189. Before that, an empty default message returned nil and an error, now it returns "" without error.

This has been detected by mattermost test suit in mattermost/mattermost#21327 which tries to switch all code base to go-i18n v2, see [related discussion](https://github.com/mattermost/mattermost/pull/21327/files#r1365634307)
@lieut-data
Copy link
Copy Markdown
Member

lieut-data commented Feb 2, 2026

Thanks for reporting this issue and for the community discussion around it. After multiple years of inactivity, we're closing this to help keep our issue tracker focused on active work. If this is still relevant, please feel free to open a new issue with updated context and we'll be happy to take another look.

@lieut-data lieut-data closed this Feb 2, 2026
@KuSh KuSh deleted the GH-5267 branch February 2, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isacikgoz isacikgoz isacikgoz left review comments

@gabrieljackson gabrieljackson Awaiting requested review from gabrieljackson

+1 more reviewer

@laneycs laneycs laneycs left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2: Dev Review Requires review by a developer Contributor Hacktoberfest hacktoberfest-accepted Lifecycle/1:stale release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for context-specific translations