MM-3943 : Update mmgotool to handle go-i18n 2.X migration#68
Closed
KuSh wants to merge 2 commits intomattermost:masterfrom
KuSh:GH-5267
Closed
MM-3943 : Update mmgotool to handle go-i18n 2.X migration#68KuSh wants to merge 2 commits intomattermost:masterfrom KuSh:GH-5267
KuSh wants to merge 2 commits intomattermost:masterfrom
KuSh:GH-5267
Conversation
Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
… to cleanup empty plural forms Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Author
|
Merged into mattermost/mattermost#21327 following switch to monorepo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modifications to mmgotool needed for PR mattermost/mattermost#21327
Previously the tool seemed to ignore space only (i.e.
" ") translations but that didn't seem right so I've changed the behavior.I've also updated the json format to use 2 space indentation to reflect current json format used in mattermost-server
Ticket Link
Fixes mattermost/mattermost#5267
Fixes https://mattermost.atlassian.net/browse/MM-3943