This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
MM-14977 Add bi-directional with loading of last unread post #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
sudheerDev
added
Work in Progress
Not yet ready for review
1: PM Review
Requires review by a product manager
Setup Old Test Server
Triggers the creation of a test server
and removed
Setup Old Test Server
Triggers the creation of a test server
labels
Jul 3, 2019
sudheerDev
added
Setup Old Test Server
Triggers the creation of a test server
and removed
Setup Old Test Server
Triggers the creation of a test server
labels
Jul 5, 2019
sudheerDev
added
Setup Old Test Server
Triggers the creation of a test server
and removed
Setup Old Test Server
Triggers the creation of a test server
labels
Jul 5, 2019
sudheerDev
added
Setup Old Test Server
Triggers the creation of a test server
and removed
Setup Old Test Server
Triggers the creation of a test server
labels
Jul 5, 2019
prevent loading older posts when a callback is in place Fix range Sync posts only if postListIds exist Sync posts only if lastPostTimestamp exists
sudheerDev
removed
the
Setup Old Test Server
Triggers the creation of a test server
label
Jul 8, 2019
sudheerDev
added
2: Dev Review
Requires review by a core commiter
Setup Old Test Server
Triggers the creation of a test server
and removed
Work in Progress
Not yet ready for review
labels
Jul 8, 2019
sudheerDev
commented
Jul 8, 2019
@@ -84,7 +84,7 @@ | |||
"copy-webpack-plugin": "5.0.3", | |||
"cross-env": "5.2.0", | |||
"css-loader": "2.1.1", | |||
"enzyme": "3.9.0", | |||
"enzyme": "3.10.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading enzyme because of enzymejs/enzyme#2020 which was needed for adding couple of test cases and also fix https://mattermost.atlassian.net/browse/MM-15837.
esethna
approved these changes
Jul 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did live testing with ST, moving to dev review so this can go through QA on daily
sudheerDev
removed
1: PM Review
Requires review by a product manager
Setup Old Test Server
Triggers the creation of a test server
labels
Jul 8, 2019
Use the new util func for selecting unread chunk Remove the check for loading posts when calling loadPosts again
hmhealey
suggested changes
Jul 9, 2019
components/suggestion/at_mention_provider/at_mention_provider.test.jsx
Outdated
Show resolved
Hide resolved
migbot
approved these changes
Jul 9, 2019
hmhealey
approved these changes
Jul 9, 2019
hmhealey
added
4: Reviews Complete
All reviewers have approved the pull request
and removed
2: Dev Review
Requires review by a core commiter
labels
Jul 9, 2019
amyblais
added
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
labels
Jul 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
4: Reviews Complete
All reviewers have approved the pull request
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
MM-11504
Related Pull Requests
https://mattermost.atlassian.net/browse/MM-11504