-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[MM-13663][MM-11504] Adds bi-directional scrolling and use unread API on channel load #2274
Conversation
* Refactor post_list to have a wrapper for calling respective posts * Use unread API for loading posts on load. * Use since or before_id based on the channel status of posts. * Clear postInChannel when entering from a view which is not at latest post * Take a backup before clearing posts as we might need it incase of network issues. * Always use oldest postId or newest postId for loading posts. * Fix async render of channelView by using a flag on channelView. * Change dependency of post_list to have channeId instead of channel. * Add channel selector for channel_intro_message component. * Add constants for AFTER_ID and BEFORE_ID.
@amyblais I believe this will be available in 5.10 not 5.8 |
@sudheerDev should we merge this against the feature branch instead of master? |
Feature branch wasn't updated in a while and there are a lot of merge conflicts so raised another PR and i thought to use this as base for future work. I am not really sure on how we should go about this. Should i fix the conflicts of feature branch and raise it against it? Feature branch has almost same code without auto-load, scroll logic and minor refactors. |
@sudheerDev I think we should keep the feature branches up to date yes! |
This issue has been automatically labelled "stale" because it hasn't had recent activity. /cc @jasonblais @hanzei |
Hey @sudheerDev, Could you please give a quick update on this PR? What is the status? |
@sudheerDev Should I add a |
@jasonblais Done changed the label on this. We mostly will be working in |
Closing this in favour of #3049 |
Summary
Adds bi-directional scrolling and uses unread API on channel load
Ticket Link
MM-13663
MM-11504
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
make check-style
to check for style errors (required for all pull requests)make test
to ensure unit and component tests passed