[MM-45850]: Migrate dot menu to MUI menu and post reminders #12007

AshishDhama · 2023-01-17T10:14:45Z

Summary

Migrate the post dot menu to the MUI menu
Note: Opening up for early review, I May add a post reminder in this or another pr. Work is done.

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-45850

Related Pull Requests

NA

Screenshots

Release Note

* Migrate post dot menu to MUI menu

AshishDhama · 2023-01-17T10:18:26Z

@M-ZubairAhmed, I think the only thing left is this new badge

M-ZubairAhmed · 2023-01-17T11:53:50Z

components/dot_menu/post_reminder_submenu.tsx

+            leadingElement={<ClockOutlineIcon size={18}/>}
+            trailingElements={<ChevronRightIcon size={16}/>}
+            menuId={`remind_post_${props.post.id}-menu`}
+            forceOpenOnLeft={true}


is the force necessary here?

Yeah, Not necessary earlier. When I was testing it, It wasn't working without it.
Maybe after your changes, it has started working without force left. Thanks for flagging.

M-ZubairAhmed · 2023-01-17T11:58:01Z

components/dot_menu/post_reminder_submenu.tsx

+            <h5 className={'postReminderMenuHeader'}>
+                {formatMessage(
+                    {id: 'post_info.post_reminder.sub_menu.header',
+                        defaultMessage: 'Set a reminder for:'},
+                )}
+            </h5>


should we make Menu.Header component? can be used in other menus as well

Seems like one-off case to me

M-ZubairAhmed · 2023-01-17T12:00:42Z

components/post_reminder_time_picker_modal/post_reminder_custom_time_picker_modal.tsx

+
+type Props = {
+    onExited: () => void;
+    userId: string;


addPostReminder , userId and isMilitaryTime can be directly derived from PropsFromRedux

M-ZubairAhmed · 2023-01-17T12:01:52Z

utils/constants.tsx

-    JOIN_LEAVE: 'system_join_leave' as const,
-    JOIN_CHANNEL: 'system_join_channel' as const,


not sure why we did like this in first place

@M-ZubairAhmed I would guess that PostTypes.JOIN_LEAVE would be a const and could not be written over

M-ZubairAhmed · 2023-01-17T12:02:47Z

packages/client/src/client4.ts

@@ -2138,6 +2138,15 @@ export default class Client4 {
        );
    }

+    addPostReminder = (userId: string, postId: string, timestamp: number) => {
+        this.trackEvent('api', 'api_post_set_reminder');


is this new telemetry key made aware to Telemetry team?

@sri-byte Please let me know, do I need to change anything here

M-ZubairAhmed · 2023-01-17T12:03:51Z

components/post_reminder_time_picker_modal/post_reminder_custom_time_picker_modal.tsx

+                        <button
+                            className='PostReminderModal__input'
+                            type='button'


curious if we can use the new menu here as well or is that not prepared for it?

M-ZubairAhmed

few comments

AshishDhama · 2023-01-17T12:54:11Z

@matthewbirtch This is a known issue. @M-ZubairAhmed will add changes tomorrow

esethna · 2023-01-18T16:29:03Z

Adding @asaadmahmood for UX review given Matt's transition

mattermost-build · 2023-02-28T18:44:19Z

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

mm-cloud-bot · 2023-03-01T05:52:40Z

New commit detected. SpinWick will upgrade if the updated docker image is available.

mm-cloud-bot · 2023-03-01T06:07:23Z

Mattermost test server updated with git commit 6a8b14243a80a9ceeff834ab48899be0a40a0ccc.

Access here: https://mattermost-webapp-pr-12007.test.mattermost.cloud

mm-cloud-bot · 2023-03-01T06:09:33Z

Test server destroyed

mm-cloud-bot · 2023-03-01T06:09:35Z

Test server destroyed

Docs for: mattermost/mattermost-webapp#12007

* Create message-reminders.rst Docs for: mattermost/mattermost-webapp#12007 * Update message-reminders.rst * Update channels.rst * Update message-reminders.rst * Update message-reminders.rst

* Update conf.py * Update deprecated-configuration-settings.rst (#6318) Doc update for: mattermost/mattermost#22422 * Create message-reminders.rst (#6322) * Create message-reminders.rst Docs for: mattermost/mattermost-webapp#12007 * Update message-reminders.rst * Update channels.rst * Update message-reminders.rst * Update message-reminders.rst * Update boards content for 7.10 (#6320) * boards update * Update source/boards/getting-started.rst Co-authored-by: Winson Wu <[email protected]> * Update source/boards/getting-started.rst Co-authored-by: Winson Wu <[email protected]> * Update share-and-collaborate.rst * Update share-and-collaborate.rst * Update get-started-with-boards.rst * Update source/boards/getting-started.rst Co-authored-by: Winson Wu <[email protected]> * Update source/boards/share-and-collaborate.rst Co-authored-by: Winson Wu <[email protected]> --------- Co-authored-by: Winson Wu <[email protected]> * Added enable board sharing configs and others (#6326) * Update cloud-subscriptions.rst * Update editions-and-offerings.rst * Update create-channels.rst * Update search-for-messages.rst * Update set-channel-preferences.rst * Update share-files-in-messages.rst * Create product-configuration-settings.rst * Update administration.rst * Update advanced-permissions.rst * Update shared-channels.rst * Update sso-gitlab.rst * Update sso-gitlab.rst * Update sso-office.rst * Update plugins-configuration-settings.rst * Update plugins-configuration-settings.rst * Update product-configuration-settings.rst * v7.10 Changelog (#6311) * Update self-managed-changelog.md * Update self-managed-changelog.md * Update self-managed-changelog.md * Update open-source-components.rst * Update release-lifecycle.rst * Update self-managed-changelog.md * Update self-managed-changelog.md * Update important-upgrade-notes.rst * Update self-managed-changelog.md * Update source/install/self-managed-changelog.md Co-authored-by: Maria A Nunez <[email protected]> * Update source/install/self-managed-changelog.md Co-authored-by: Winson Wu <[email protected]> * Apply suggestions from code review Co-authored-by: Carrie Warner (Mattermost) <[email protected]> * Update self-managed-changelog.md * Update self-managed-changelog.md * Update self-managed-changelog.md * Update self-managed-changelog.md * Update self-managed-changelog.md * Update self-managed-changelog.md * Update self-managed-changelog.md --------- Co-authored-by: Maria A Nunez <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Carrie Warner (Mattermost) <[email protected]> --------- Co-authored-by: Justine Geffen <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Maria A Nunez <[email protected]> Co-authored-by: Carrie Warner (Mattermost) <[email protected]>

mm-cloud-bot added the release-note label Jan 17, 2023

AshishDhama requested review from M-ZubairAhmed and hmhealey January 17, 2023 10:14

AshishDhama self-assigned this Jan 17, 2023

AshishDhama changed the title ~~[MM-45850]: post reminders~~ [MM-45850]: Migrate dot menu to MUI menu and post reminders Jan 17, 2023

AshishDhama added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jan 17, 2023

AshishDhama requested a review from matthewbirtch January 17, 2023 10:18

AshishDhama force-pushed the MM-45850_post-reminders branch from ebb350b to 329a179 Compare January 17, 2023 10:40

M-ZubairAhmed reviewed Jan 17, 2023

View reviewed changes

AshishDhama removed request for matthewbirtch and hmhealey January 17, 2023 12:01

M-ZubairAhmed reviewed Jan 17, 2023

View reviewed changes

AshishDhama requested a review from matthewbirtch January 17, 2023 12:52

AshishDhama force-pushed the MM-45850_post-reminders branch from 7de2a00 to af9628f Compare January 17, 2023 13:03

AshishDhama added the 1: UX Review Requires review by a UX Designer label Jan 17, 2023

esethna requested review from asaadmahmood and removed request for matthewbirtch January 18, 2023 16:28

esethna closed this Jan 18, 2023

mattermost-build removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jan 18, 2023

esethna reopened this Jan 18, 2023

esethna added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jan 18, 2023

mm-cloud-bot removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jan 18, 2023

furqanmlk self-requested a review February 28, 2023 20:16

furqanmlk approved these changes Feb 28, 2023

View reviewed changes

AshishDhama added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Mar 1, 2023

fix stack size error

6a8b142

AshishDhama merged commit c91f98c into master Mar 1, 2023

AshishDhama deleted the MM-45850_post-reminders branch March 1, 2023 06:09

mattermost-build removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Mar 1, 2023

amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation Docs/Needed Requires documentation and removed Docs/Not Needed Does not require documentation labels Mar 1, 2023

amyblais added this to the v7.10.0 milestone Mar 2, 2023

amyblais unassigned AshishDhama Mar 20, 2023

errotu mentioned this pull request Mar 31, 2023

Add webapp feature for reminders from post 'more actions' ellipsis scottleedavis/mattermost-plugin-remind#73

Closed

justinegeffen added Docs/Done Required documentation has been written Docs/Needed Requires documentation and removed Docs/Needed Requires documentation Docs/Done Required documentation has been written labels Apr 11, 2023

justinegeffen added a commit to mattermost/docs that referenced this pull request Apr 11, 2023

Create message-reminders.rst

fbc441a

Docs for: mattermost/mattermost-webapp#12007

justinegeffen mentioned this pull request Apr 11, 2023

Create message-reminders.rst mattermost/docs#6322

Merged

justinegeffen added Docs/Done Required documentation has been written and removed Docs/Needed Requires documentation labels Apr 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MM-45850]: Migrate dot menu to MUI menu and post reminders #12007

[MM-45850]: Migrate dot menu to MUI menu and post reminders #12007

AshishDhama commented Jan 17, 2023 •

edited

Loading

AshishDhama commented Jan 17, 2023

M-ZubairAhmed Jan 17, 2023

AshishDhama Jan 17, 2023 •

edited

Loading

M-ZubairAhmed Jan 17, 2023

AshishDhama Jan 17, 2023

M-ZubairAhmed Jan 17, 2023 •

edited

Loading

M-ZubairAhmed Jan 17, 2023

koox00 Mar 2, 2023

M-ZubairAhmed Jan 17, 2023

AshishDhama Feb 16, 2023

M-ZubairAhmed Jan 17, 2023 •

edited

Loading

M-ZubairAhmed left a comment

AshishDhama commented Jan 17, 2023

esethna commented Jan 18, 2023

mattermost-build commented Feb 28, 2023

mm-cloud-bot commented Mar 1, 2023

mm-cloud-bot commented Mar 1, 2023

mm-cloud-bot commented Mar 1, 2023

mm-cloud-bot commented Mar 1, 2023

		JOIN_LEAVE: 'system_join_leave' as const,
		JOIN_CHANNEL: 'system_join_channel' as const,

[MM-45850]: Migrate dot menu to MUI menu and post reminders #12007

[MM-45850]: Migrate dot menu to MUI menu and post reminders #12007

Conversation

AshishDhama commented Jan 17, 2023 • edited Loading

Summary

Ticket Link

Related Pull Requests

Screenshots

Release Note

AshishDhama commented Jan 17, 2023

M-ZubairAhmed Jan 17, 2023

Choose a reason for hiding this comment

AshishDhama Jan 17, 2023 • edited Loading

Choose a reason for hiding this comment

M-ZubairAhmed Jan 17, 2023

Choose a reason for hiding this comment

AshishDhama Jan 17, 2023

Choose a reason for hiding this comment

M-ZubairAhmed Jan 17, 2023 • edited Loading

Choose a reason for hiding this comment

M-ZubairAhmed Jan 17, 2023

Choose a reason for hiding this comment

koox00 Mar 2, 2023

Choose a reason for hiding this comment

M-ZubairAhmed Jan 17, 2023

Choose a reason for hiding this comment

AshishDhama Feb 16, 2023

Choose a reason for hiding this comment

M-ZubairAhmed Jan 17, 2023 • edited Loading

Choose a reason for hiding this comment

M-ZubairAhmed left a comment

Choose a reason for hiding this comment

AshishDhama commented Jan 17, 2023

esethna commented Jan 18, 2023

mattermost-build commented Feb 28, 2023

mm-cloud-bot commented Mar 1, 2023

mm-cloud-bot commented Mar 1, 2023

mm-cloud-bot commented Mar 1, 2023

mm-cloud-bot commented Mar 1, 2023

AshishDhama commented Jan 17, 2023 •

edited

Loading

AshishDhama Jan 17, 2023 •

edited

Loading

M-ZubairAhmed Jan 17, 2023 •

edited

Loading

M-ZubairAhmed Jan 17, 2023 •

edited

Loading