Skip to content
This repository was archived by the owner on Mar 13, 2024. It is now read-only.

MM-46343: Include E2Es for colorized usernames in compact view#10942

Merged
mvitale1989 merged 7 commits into
mattermost:masterfrom
sinansonmez:MM-46343-e2e-test-for-colorized-names
Aug 22, 2022
Merged

MM-46343: Include E2Es for colorized usernames in compact view#10942
mvitale1989 merged 7 commits into
mattermost:masterfrom
sinansonmez:MM-46343-e2e-test-for-colorized-names

Conversation

@sinansonmez
Copy link
Copy Markdown
Contributor

@sinansonmez sinansonmez commented Aug 15, 2022 •
edited
Loading

Summary

This PR includes E2Es for colorized usernames in compact view based on suggested steps

Ticket Link

Fixes mattermost/mattermost#20813
JIRA: https://mattermost.atlassian.net/browse/MM-46343

Release Note

NONE

@mattermod
Copy link
Copy Markdown
Contributor

mattermod commented Aug 15, 2022

Hello @sinansonmez,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@mattermod mattermod requested review from a team and hmhealey and removed request for a team August 15, 2022 20:54
@mattermod mattermod added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester Contributor labels Aug 15, 2022
@mattermod
Copy link
Copy Markdown
Contributor

mattermod commented Aug 15, 2022

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

@M-ZubairAhmed M-ZubairAhmed requested review from furqanmlk and saturninoabril and removed request for hmhealey August 16, 2022 05:44
@sinansonmez
Copy link
Copy Markdown
Contributor Author

sinansonmez commented Aug 16, 2022

I also saw in JIRA that there will be an effort to migrate E2E tests to typescript. If the groundwork is ready, I can convert this file to typescript. Please let me know.

@furqanmlk
Copy link
Copy Markdown
Contributor

furqanmlk commented Aug 16, 2022

I also saw in JIRA that there will be an effort to migrate E2E tests to typescript. If the groundwork is ready, I can convert this file to typescript. Please let me know.

@sinansonmez
We have one PR ready need to get it ready for review. you can get that if you want
#10910

@furqanmlk
Copy link
Copy Markdown
Contributor

furqanmlk commented Aug 16, 2022 •
edited
Loading

/e2e-test

@mattermod
Copy link
Copy Markdown
Contributor

mattermod commented Aug 16, 2022

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/230161

furqanmlk
furqanmlk reviewed Aug 16, 2022
View reviewed changes
Comment thread e2e/cypress/tests/integration/settings/display/message_display_mode_colorize_username_spec.js Outdated
Comment thread e2e/cypress/tests/integration/settings/display/message_display_mode_colorize_username_spec.js Outdated
Comment thread e2e/cypress/tests/integration/settings/display/message_display_mode_colorize_username_spec.js Outdated
Comment thread e2e/cypress/tests/integration/settings/display/message_display_mode_colorize_username_spec.js Outdated
Comment thread e2e/cypress/tests/integration/settings/display/message_display_mode_colorize_username_spec.js
@sinansonmez sinansonmez requested a review from furqanmlk August 16, 2022 20:48
@furqanmlk
Copy link
Copy Markdown
Contributor

furqanmlk commented Aug 16, 2022

/e2e-test

@mattermod
Copy link
Copy Markdown
Contributor

mattermod commented Aug 16, 2022

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/230205

@saturninoabril saturninoabril requested review from mvitale1989 and removed request for saturninoabril August 17, 2022 07:21
furqanmlk
furqanmlk approved these changes Aug 17, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sinansonmez 👍
LGTM

mvitale1989
mvitale1989 reviewed Aug 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mvitale1989 mvitale1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This overall LGTM, I proposed one idea to avoid hardcoding the color, but i'm also fine with your current version if for some reason my proposal turns out cumbersome to implement.

Comment thread e2e/cypress/tests/integration/settings/display/message_display_mode_colorize_username_spec.js Outdated
@sinansonmez sinansonmez requested a review from a team as a code owner August 20, 2022 12:14
@metanerd metanerd requested a review from mvitale1989 August 20, 2022 14:57
mvitale1989
mvitale1989 approved these changes Aug 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mvitale1989 mvitale1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, lgtm now!

@mvitale1989 mvitale1989 removed the 3: QA Review Requires review by a QA tester label Aug 22, 2022
@mvitale1989
Copy link
Copy Markdown
Contributor

mvitale1989 commented Aug 22, 2022

/e2e-test

@mattermod
Copy link
Copy Markdown
Contributor

mattermod commented Aug 22, 2022

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/232095

@mvitale1989 mvitale1989 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Aug 22, 2022
@mvitale1989 mvitale1989 merged commit 2ff82e6 into mattermost:master Aug 22, 2022
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@furqanmlk furqanmlk furqanmlk approved these changes

@mvitale1989 mvitale1989 mvitale1989 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Contributor Docs/Not Needed Does not require documentation release-note-none

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Write E2Es for colorized usernames in compact view

6 participants

@sinansonmez @mattermod @furqanmlk @mvitale1989 @amyblais @mm-cloud-bot