Migrated support files and accessibility sidebar spec file to Typescript#10910
Conversation
|
/e2e-test |
|
Successfully triggered e2e testing! |
|
/e2e-test |
|
Successfully triggered e2e testing! |
furqanmlk
changed the title
… Cypress-to-Typescript-Accessibility_sidebar_spec
…thub.com:mattermost/mattermost-webapp into Cypress-to-Typescript-Accessibility_sidebar_spec
|
/e2e-test |
|
Successfully triggered e2e testing! |
saturninoabril
requested review from
mvitale1989
and removed request for
saturninoabril
neallred
left a comment
neallred
left a comment
There was a problem hiding this comment.
Nice work! Cool to see the tests still passing. It looks like we can remove some of the declaration files for files that were migrated: e2e/cypress/tests/support/task_commands.d.ts, e2e/cypress/tests/support/ui_commands.d.ts, e2e/cypress/tests/support/ui/post.d.ts.
Could you make sure that the npm run check-types command completes successfully when run locally from the e2e/cypress directory? I'm getting a number of errors when I run it locally. I should have added running that step to the CI pipelines in the PR that introduced Typescript support, but missed it. We should probably add a ticket to do that as part of the e2e typescript migration; it will avoid conflicts and confusion if we make sure that each change type checks automatically.
joebigboi
left a comment
joebigboi
left a comment
There was a problem hiding this comment.
LGTM. Just one minor query
| const setCookie = response.headers['set-cookie']; | ||
| setCookie.forEach((cookie) => { | ||
| (setCookie as any).forEach((cookie: string) => { |
There was a problem hiding this comment.
shouldn't this be const setCookie: string[] = response.headers['set-cookie']; and then you can write setCookie.forEach((cookie) => {
mvitale1989
left a comment
mvitale1989
left a comment
There was a problem hiding this comment.
Tests are passing, and afaict this looks good to me
|
@neallred |
furqanmlk
force-pushed
the
Cypress-to-Typescript-Accessibility_sidebar_spec
branch
from
46b2415 to
4389091
Compare
neallred
left a comment
neallred
left a comment
There was a problem hiding this comment.
LGTM, thanks @furqanmlk !
|
/e2e-test |
8 participants
Summary
Converted following support files
e2e/cypress/tests/support/ui/sidebar_left.tse2e/cypress/tests/support/task_commands.tse2e/cypress/tests/plugins/external_request.tse2e/cypress/tests/support/api_commands.tse2e/cypress/tests/support/env.tse2e/cypress/tests/support/task_commands.tse2e/cypress/tests/support/ui/post.tse2e/cypress/tests/support/ui/sidebar_left.tsand one spec file
accessibility_sidebar_spec.tsTicket Link
https://mattermost.atlassian.net/browse/MM-45968
Screenshots
Release Note