Skip to content

Added check for the 'show' prop before making API request for the link tooltip. #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mickmister merged 4 commits into from
Feb 9, 2024
Merged

Added check for the 'show' prop before making API request for the link tooltip. #453

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6ef44f
[MM-197] Added check for the 'show' prop before making API request fo…
Feb 7, 2024
1e23da4
[MM-197] Fix lint error
Feb 7, 2024
b8940f8
[MM-197] Review fixe
Feb 8, 2024
1485e82
[MM-197] Review fix: returned "null" from the component when "show" p…
Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions webapp/src/components/link_tooltip/link_tooltip.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,14 @@ export const getInfoAboutLink = (href, hostname) => {
return {};
};

export const LinkTooltip = ({href, connected, gitlabURL}) => {
export const LinkTooltip = ({href, connected, gitlabURL, show}) => {
const [data, setData] = useState(null);
const dispatch = useDispatch();
useEffect(() => {
if (!connected || !show) {
return;
}

if (!isValidUrl(href)) {
return;
}
Expand Down Expand Up @@ -74,12 +78,8 @@ export const LinkTooltip = ({href, connected, gitlabURL}) => {
}
};

if (!connected) {
return;
}

init();
}, [connected, href]);
}, [connected, href, show]);

const getIconElement = () => {
const iconProps = {
Expand Down Expand Up @@ -118,7 +118,7 @@ export const LinkTooltip = ({href, connected, gitlabURL}) => {
);
};

if (!data) {
if (!data || !show) {
return null;
}

Expand Down Expand Up @@ -210,4 +210,5 @@ LinkTooltip.propTypes = {
href: PropTypes.string.isRequired,
connected: PropTypes.bool.isRequired,
gitlabURL: PropTypes.string.isRequired,
show: PropTypes.bool,
};