Added check for the 'show' prop before making API request for the link tooltip.#453
Merged
mickmister merged 4 commits intomattermost:masterfrom Feb 9, 2024
Merged
Added check for the 'show' prop before making API request for the link tooltip.#453mickmister merged 4 commits intomattermost:masterfrom
mickmister merged 4 commits intomattermost:masterfrom
Conversation
…r the link tooltip.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #453 +/- ##
==========================================
- Coverage 33.50% 33.38% -0.12%
==========================================
Files 22 22
Lines 4000 4014 +14
==========================================
Hits 1340 1340
- Misses 2527 2541 +14
Partials 133 133 ☔ View full report in Codecov by Sentry. |
mickmister
approved these changes
Feb 7, 2024
mickmister
approved these changes
Feb 8, 2024
Contributor
|
I'm thinking we should also have the return value of the component be mattermost-plugin-gitlab/webapp/src/components/link_tooltip/link_tooltip.jsx Lines 121 to 123 in b8940f8 |
Author
|
@mickmister Updated |
mickmister
approved these changes
Feb 9, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What to test?
Steps to test:
Ticket Link
Fixes: https://community.mattermost.com/core/pl/zao9gnwgjpf6mmeo9y9xu8kngy