Added a message to create a subscription after running the pipeline (#341)#445
Closed
avas27JTG wants to merge 6 commits intomattermost:masterfrom
Closed
Added a message to create a subscription after running the pipeline (#341)#445avas27JTG wants to merge 6 commits intomattermost:masterfrom
avas27JTG wants to merge 6 commits intomattermost:masterfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #445 +/- ##
==========================================
- Coverage 33.40% 33.21% -0.19%
==========================================
Files 22 22
Lines 3979 4001 +22
==========================================
Hits 1329 1329
- Misses 2519 2541 +22
Partials 131 131 ☔ View full report in Codecov by Sentry. |
avas27JTG
changed the title
Contributor
|
I think this is already implemented here right? #433 |
|
@mickmister I think there was some confusion here. We can close this PR and continue with #433 as that is already in the review process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a message to create a subscription after running the pipeline (#341)
Screenshot
In case of no existing subscription for the given project
In case of an existing subscription for the given project but a different feature than the pipeline
Ticket Link
Fixes #341