[MM-99] Added a note to create subscription for "pipeline" event after running a pipeline#433
Conversation
…r running a pipeline
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #433 +/- ##
==========================================
- Coverage 33.40% 33.28% -0.12%
==========================================
Files 22 22
Lines 3979 3993 +14
==========================================
Hits 1329 1329
- Misses 2519 2533 +14
Partials 131 131 ☔ View full report in Codecov by Sentry. |
mickmister
left a comment
There was a problem hiding this comment.
LGTM, just one suggestion
server/command.go
Outdated
| foundPipelineSubscription := false | ||
| subs, err := p.GetSubscriptionsByChannel(channelID) | ||
| if err != nil { | ||
| p.API.LogWarn("Failed to get subscriptions for the channel", "ChannelID", channelID, "Error", err.Error()) |
There was a problem hiding this comment.
0/5 we should use the pluginapi package when possible
| p.API.LogWarn("Failed to get subscriptions for the channel", "ChannelID", channelID, "Error", err.Error()) | |
| p.client.Log.Warn("Failed to get subscriptions for the channel", "channel_id", channelID, "error", err.Error()) |
There was a problem hiding this comment.
0/5 we should use the pluginapi package when possible
@mickmister Are you referring to this https://pkg.go.dev/github.com/mattermost/mattermost-plugin-api package?
There was a problem hiding this comment.
@raghavaggarwal2308 That is the old location of that package. It's now at https://pkg.go.dev/github.com/mattermost/mattermost/server/public/pluginapi
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
AayushChaudhary0001
left a comment
There was a problem hiding this comment.
This PR has been tested for the following scenario:-
- Note added for running pipeline of the subscription is not already created.
This PR was working fine for the above condition, LGTM. Approved.
Summary
Added a note to create subscription for "pipeline" event after running a pipeline
Screenshot:
What to test?
Steps to reproduce:
/gitlab pipelines run <org/repo> <branch-name>Ticket Link
Fixes #341