[MM-53944] Make use of github.com/mattermost/mattermost/server/public#393
Merged
[MM-53944] Make use of github.com/mattermost/mattermost/server/public#393
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #393 +/- ##
=======================================
Coverage 32.93% 32.94%
=======================================
Files 22 22
Lines 4014 4013 -1
=======================================
Hits 1322 1322
+ Misses 2561 2560 -1
Partials 131 131
☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
@spirosoik Would you mind giving this PR a review so we can get it into 1.7.0? |
Collaborator
Author
|
I did a smoke test of the change (compile the plugin, start it, and run a slash command). Is that enough? More complex issues might also be caught during release testing. |
spirosoik
approved these changes
Aug 23, 2023
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes use of the newly created go module in https://pkg.go.dev/github.com/mattermost/mattermost/server/public.
See mattermost/mattermost-plugin-demo#163 for a similar migration.
Ticket Link
https://mattermost.atlassian.net/browse/MM-53944