[MM-53944] Make use of github.com/mattermost/mattermost/server/public#163
Merged
[MM-53944] Make use of github.com/mattermost/mattermost/server/public#163
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #163 +/- ##
=========================================
- Coverage 2.06% 2.06% -0.01%
=========================================
Files 14 14
Lines 1741 1746 +5
=========================================
Hits 36 36
- Misses 1703 1708 +5
Partials 2 2
☔ View full report in Codecov by Sentry. |
hanzei
force-pushed
the
MM-53944_use-public
branch
from
bb4a70b to
7f122f2
Compare
lieut-data
previously requested changes
Aug 8, 2023
Member
lieut-data
left a comment
lieut-data
left a comment
There was a problem hiding this comment.
Nice, @hanzei! Just one thought below :)
hanzei
added
the
Do Not Merge/Awaiting PR
mickmister
approved these changes
Aug 15, 2023
hanzei
removed
the
Do Not Merge/Awaiting PR
Contributor
Author
|
@cpoile Would you mind giving this PR a review while @lieut-data is out? |
hanzei
added
4: Reviews Complete
Contributor
Author
|
I did some smoke testing and didn't run into issues. Merging 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes use of the newly created go module in https://pkg.go.dev/github.com/mattermost/mattermost/server/public.
It also sync the tooling with https://github.com/mattermost/mattermost-plugin-starter-template.
Ticket Link
https://mattermost.atlassian.net/browse/MM-53944