Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
=======================================
Coverage 39.89% 39.89%
=======================================
Files 16 16
Lines 1494 1494
=======================================
Hits 596 596
Misses 838 838
Partials 60 60 Continue to review full report at Codecov.
|
manland
approved these changes
Apr 10, 2020
iomodo
approved these changes
Apr 10, 2020
hanzei
added
the
4: Reviews Complete
ayusht2810
pushed a commit
that referenced
this pull request
Jan 31, 2024
#192) * Revert "Update main.go (#154)" This reverts commit be4a281d0cc791d10e6e5ae917b325b2f054e475. * Revert "[MM-33506] Use embed package to include plugin manifest (#145)" This reverts commit ca9ee3c17c6920a636a33f378e17395afd6f329f. * Revert "Don't generate manifest.ts (#127)" This reverts commit 18d30b50bc7ba800c9f05bfd82970781db0aea3e. * install-go-tools target, adopt gotestsum * bring back make apply + automatic versioning * Update build/manifest/main.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * suppress git describe error when no tags match * make version/release notes opt-in * fix whitespace in Makefile * document version management options --------- Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> Signed-off-by: ayusht2810 <ayush.thakur@brightscout.com>
mickmister
added a commit
that referenced
this pull request
Feb 1, 2024
* Sync with playbooks: install-go-tools, gotestsum, and dynamic versions (#192) * Revert "Update main.go (#154)" This reverts commit be4a281d0cc791d10e6e5ae917b325b2f054e475. * Revert "[MM-33506] Use embed package to include plugin manifest (#145)" This reverts commit ca9ee3c17c6920a636a33f378e17395afd6f329f. * Revert "Don't generate manifest.ts (#127)" This reverts commit 18d30b50bc7ba800c9f05bfd82970781db0aea3e. * install-go-tools target, adopt gotestsum * bring back make apply + automatic versioning * Update build/manifest/main.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * suppress git describe error when no tags match * make version/release notes opt-in * fix whitespace in Makefile * document version management options --------- Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> Signed-off-by: ayusht2810 <ayush.thakur@brightscout.com> * Fetch plugin logs from server (#193) Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> * [MM-176] Fix lint errors --------- Signed-off-by: ayusht2810 <ayush.thakur@brightscout.com> Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
CODEOWNERSfiles and mentioning the maintainer inREADME.md.I also dropped
.vscode/as it's not idiomatic to have a editor specific folder in a repo.Ticket Link
https://community-release.mattermost.com/core/pl/kpxpc6kkabnodkg6o3en1wh5gh