Skip to content

go mod tidy#145

Merged
hanzei merged 1 commit intomasterfrom
tidy
Mar 26, 2020
Merged

go mod tidy#145
hanzei merged 1 commit intomasterfrom
tidy

Conversation

@hanzei
Copy link
Copy Markdown
Collaborator

@hanzei hanzei commented Mar 26, 2020

Summary

Run go mod tidỳ. In the near feature go mod tidy will be enforced by CI.

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Mar 26, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2020

Codecov Report

Merging #145 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   39.89%   39.89%           
=======================================
  Files          16       16           
  Lines        1494     1494           
=======================================
  Hits          596      596           
  Misses        838      838           
  Partials       60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d5300...0a4968c. Read the comment docs.

@hanzei hanzei requested review from larkox and manland March 26, 2020 12:53
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 26, 2020
@hanzei hanzei merged commit 6b50a76 into master Mar 26, 2020
@hanzei hanzei deleted the tidy branch March 26, 2020 13:29
@hanzei hanzei added this to the v1.2.0 milestone Mar 26, 2020
ayusht2810 pushed a commit that referenced this pull request Jan 31, 2024
#192)

* Revert "Update main.go (#154)"

This reverts commit be4a281d0cc791d10e6e5ae917b325b2f054e475.

* Revert "[MM-33506] Use embed package to include plugin manifest (#145)"

This reverts commit ca9ee3c17c6920a636a33f378e17395afd6f329f.

* Revert "Don't generate manifest.ts (#127)"

This reverts commit 18d30b50bc7ba800c9f05bfd82970781db0aea3e.

* install-go-tools target, adopt gotestsum

* bring back make apply + automatic versioning

* Update build/manifest/main.go

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

* suppress git describe error when no tags match

* make version/release notes opt-in

* fix whitespace in Makefile

* document version management options

---------

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Signed-off-by: ayusht2810 <ayush.thakur@brightscout.com>
mickmister added a commit that referenced this pull request Feb 1, 2024
* Sync with playbooks: install-go-tools, gotestsum, and dynamic versions (#192)

* Revert "Update main.go (#154)"

This reverts commit be4a281d0cc791d10e6e5ae917b325b2f054e475.

* Revert "[MM-33506] Use embed package to include plugin manifest (#145)"

This reverts commit ca9ee3c17c6920a636a33f378e17395afd6f329f.

* Revert "Don't generate manifest.ts (#127)"

This reverts commit 18d30b50bc7ba800c9f05bfd82970781db0aea3e.

* install-go-tools target, adopt gotestsum

* bring back make apply + automatic versioning

* Update build/manifest/main.go

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

* suppress git describe error when no tags match

* make version/release notes opt-in

* fix whitespace in Makefile

* document version management options

---------

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Signed-off-by: ayusht2810 <ayush.thakur@brightscout.com>

* Fetch plugin logs from server (#193)

Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>

* [MM-176] Fix lint errors

---------

Signed-off-by: ayusht2810 <ayush.thakur@brightscout.com>
Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: Reviews Complete All reviewers have approved the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants