Fix missing PR notifications when using both pulls_created and pulls_merged features filter #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…merged Signed-off-by: Vadim Aleksandrov <[email protected]>
wiggin77
added
2: Dev Review
|
Thanks @verdel |
raghavaggarwal2308
approved these changes
Oct 3, 2024
Thank you for taking the time to review my PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is currently a bug described in the linked issue below. If both
pulls_createdandpulls_mergedfeatures are set for a subscription, any type of PR events are ignored.I have fixed the
ifstatement, and now it is possible to use both values and receive notifications for the respective event types.Ticket Link
Fixes #826