Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR event notifications not created when pulls_created and pulls_merged are used simultaneously #826

Open
verdel opened this issue Sep 23, 2024 · 0 comments · May be fixed by #829
Open

PR event notifications not created when pulls_created and pulls_merged are used simultaneously #826

verdel opened this issue Sep 23, 2024 · 0 comments · May be fixed by #829
Labels
Type/Bug Something isn't working

Comments

@verdel
Copy link

verdel commented Sep 23, 2024

If we use the following command when creating a subscription:

/github subscriptions add test/test --features pulls_created,pulls_merged

Then, when a webhook is sent with any PR event types, no notification is created in the channel.

This is caused by how the webhook event is processed in this part of the code.

Currently, there is a limitation on using the features type in subscriptions. We either need to modify the if statement to allow both types of features to be used simultaneously, or add a restriction on using both types at the same time, similar to how it is done with pulls,pulls_created or pulls,pulls_merged, as shown here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type/Bug Something isn't working
Projects
2 participants