Skip to content

[MM-107] Update plugin with respect to phase 1 upgrades#123

Merged
mickmister merged 4 commits intomattermost-community:masterfrom
Brightscout:MM-107
May 24, 2024
Merged

[MM-107] Update plugin with respect to phase 1 upgrades#123
mickmister merged 4 commits intomattermost-community:masterfrom
Brightscout:MM-107

Conversation

@ayusht2810
Copy link
Copy Markdown
Contributor

Summary

Updated plugin with respect to phase 1 upgrades

Ticket Link

@ayusht2810 ayusht2810 requested a review from mickmister as a code owner January 9, 2024 12:52
@ayusht2810 ayusht2810 self-assigned this Jan 9, 2024
@ayusht2810 ayusht2810 added the 2: Dev Review Requires review by a core committer label Jan 9, 2024
@ayusht2810
Copy link
Copy Markdown
Contributor Author

@mickmister Should we assign a QA to test the PR?

@mickmister
Copy link
Copy Markdown
Contributor

I think we can delay to release testing on these PRs. On a side note, I wonder why CI is not running properly here. There are no GitHub actions running. Note that we want to include the changes from mattermost/mattermost-plugin-starter-template#192 here

@mickmister
Copy link
Copy Markdown
Contributor

/update-branch

@mattermost-build
Copy link
Copy Markdown

We don't have permissions to update this PR, please contact the submitter to apply the update.

…nd and installing go-tools and dynamic version for plugin
@ayusht2810 ayusht2810 requested a review from mickmister January 31, 2024 07:35
@ayusht2810
Copy link
Copy Markdown
Contributor Author

@mickmister synced the PR with the starter template to include some more changes.

@mickmister
Copy link
Copy Markdown
Contributor

mickmister commented Feb 15, 2024

@toninis Any ideas why CI is not running on this PR? same with mattermost-community/mattermost-plugin-webex#75

@mickmister
Copy link
Copy Markdown
Contributor

@ayusht2810 Can you please run the CI commands locally?

@Kshitij-Katiyar
Copy link
Copy Markdown
Contributor

@ayusht2810 Can you please run the CI commands locally?

@mickmister Done it is running successfully.

@mickmister
Copy link
Copy Markdown
Contributor

@toninis CI is not running for this plugin PR nor mattermost-community/mattermost-plugin-webex#75. Any idea why this may be the case?

@mickmister
Copy link
Copy Markdown
Contributor

@raghavaggarwal2308 Can you please give this PR a review?

@toninis
Copy link
Copy Markdown
Contributor

toninis commented Mar 19, 2024

@ayusht2810 please create a new empty commit to retrigger the worfklow

git commit --allow-empty -m "Empty-Commit to retrigger workflow" ; git push

@Kshitij-Katiyar
Copy link
Copy Markdown
Contributor

@ayusht2810 please create a new empty commit to retrigger the worfklow

git commit --allow-empty -m "Empty-Commit to retrigger workflow" ; git push

@toninis Pushed an empty commit but i don't think the workflows have been triggered here.

@mickmister
Copy link
Copy Markdown
Contributor

@Kshitij-Katiyar It looks like the workflows have run now

@Kshitij-Katiyar Kshitij-Katiyar added this to the v1.4.0 milestone Apr 12, 2024
Copy link
Copy Markdown

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this PR, working fine for all the major functionalities, LGTM. Approved.
(Tested on MM version 9+ and 7.8.0 since the plugin is not working perfectly on the minimum supported version)

@mickmister mickmister added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels May 24, 2024
@mickmister mickmister merged commit cd4627a into mattermost-community:master May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: Reviews Complete All reviewers have approved the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants