[MM-107] Update plugin with respect to phase 1 upgrades#123
[MM-107] Update plugin with respect to phase 1 upgrades#123mickmister merged 4 commits intomattermost-community:masterfrom
Conversation
|
@mickmister Should we assign a QA to test the PR? |
|
I think we can delay to release testing on these PRs. On a side note, I wonder why CI is not running properly here. There are no GitHub actions running. Note that we want to include the changes from mattermost/mattermost-plugin-starter-template#192 here |
|
/update-branch |
|
We don't have permissions to update this PR, please contact the submitter to apply the update. |
…nd and installing go-tools and dynamic version for plugin
|
@mickmister synced the PR with the starter template to include some more changes. |
|
@toninis Any ideas why CI is not running on this PR? same with mattermost-community/mattermost-plugin-webex#75 |
|
@ayusht2810 Can you please run the CI commands locally? |
@mickmister Done it is running successfully. |
|
@toninis CI is not running for this plugin PR nor mattermost-community/mattermost-plugin-webex#75. Any idea why this may be the case? |
|
@raghavaggarwal2308 Can you please give this PR a review? |
|
@ayusht2810 please create a new empty commit to retrigger the worfklow |
@toninis Pushed an empty commit but i don't think the workflows have been triggered here. |
|
@Kshitij-Katiyar It looks like the workflows have run now |
AayushChaudhary0001
left a comment
There was a problem hiding this comment.
Tested this PR, working fine for all the major functionalities, LGTM. Approved.
(Tested on MM version 9+ and 7.8.0 since the plugin is not working perfectly on the minimum supported version)
Summary
Updated plugin with respect to phase 1 upgrades
nvmrcfile.Ticket Link