[MM-109] Update plugin with respect to phase 1 upgrades#75
Merged
mickmister merged 4 commits intomattermost-community:masterfrom Mar 18, 2024
Merged
[MM-109] Update plugin with respect to phase 1 upgrades#75mickmister merged 4 commits intomattermost-community:masterfrom
mickmister merged 4 commits intomattermost-community:masterfrom
Conversation
cpoile
approved these changes
Jan 13, 2024
Contributor
cpoile
left a comment
cpoile
left a comment
There was a problem hiding this comment.
I'm approving, assuming the changes are in line with our standards for plugins (@mickmister ?).
mickmister
approved these changes
Feb 15, 2024
mickmister
added
the
Do Not Merge
Contributor
|
Waiting on mattermost-community/mattermost-plugin-welcomebot#123 (comment) before merging |
…s (#192) * Revert "Update main.go (#154)" This reverts commit be4a281d0cc791d10e6e5ae917b325b2f054e475. * Revert "[MM-33506] Use embed package to include plugin manifest (#145)" This reverts commit ca9ee3c17c6920a636a33f378e17395afd6f329f. * Revert "Don't generate manifest.ts (#127)" This reverts commit 18d30b50bc7ba800c9f05bfd82970781db0aea3e. * install-go-tools target, adopt gotestsum * bring back make apply + automatic versioning * Update build/manifest/main.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * suppress git describe error when no tags match * make version/release notes opt-in * fix whitespace in Makefile * document version management options --------- Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>
Contributor
|
@ayusht2810 Can you please run the CI commands locally? |
Contributor
@mickmister I ran the CI commands locally and found some lint errors which I have fixed as well. |
mickmister
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated plugin with respect to phase 1 upgrades
nvmrcfile and updatedpackage-lock.jsonfile.Ticket Link