-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature to show hidden card count #3094
Feature to show hidden card count #3094
Conversation
…t-community#2354) (mattermost-community#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]>
Added one more merged PR to the list
…-community#2492) (mattermost-community#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]>
…munity#2480) (mattermost-community#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]>
…attermost-community#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test
…attermost-community#2497) (mattermost-community#2503) (cherry picked from commit f9cef8e) Co-authored-by: Asaad Mahmood <[email protected]>
… (mattermost-community#2504) (cherry picked from commit 20fe19a) Co-authored-by: Scott Bishel <[email protected]>
…termost-community#2510) (cherry picked from commit 4cb3a0f) Co-authored-by: Jesús Espino <[email protected]>
…-community#2499) (mattermost-community#2515) (cherry picked from commit 61f1a3c) Co-authored-by: Scott Bishel <[email protected]>
…munity#2479) (mattermost-community#2517) * mattermost-communityGH-2447 - Updating label overflow * Updating labels css (cherry picked from commit 923437c) Co-authored-by: Asaad Mahmood <[email protected]>
…community#2511) (mattermost-community#2522) * mattermost-communityGh-2437 - Updating share board modal * Updating test * Updating card dialog and test * Updating comment list (cherry picked from commit 50ded69) Co-authored-by: Asaad Mahmood <[email protected]>
…nity#2523) * updated/synced prior PR * add title back for cypress tests * update unit test for cypress fix * move to function Co-authored-by: Mattermod <[email protected]> (cherry picked from commit 5b309e8) Co-authored-by: Scott Bishel <[email protected]>
…ommunity#2532) (cherry picked from commit 84a3f8f) Co-authored-by: Doug Lauder <[email protected]>
…munity#2531) * Shows "(Deleted User)" instead of UUID when user not found (mattermost-community#2354) (mattermost-community#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * Added ability to dismiss tour from overlay * mattermost-communityGH-2212 - Update global link on board (mattermost-community#2492) (mattermost-community#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * mattermost-communityGH-2387 - Fixing link in comments (mattermost-community#2480) (mattermost-community#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (mattermost-community#2468) * Fixed a bug where images of the welcome board were not copied over. (mattermost-community#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * Fixed intended behavio * lint fixes * Fixed tests * Fixed tests Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Mattermod <[email protected]> (cherry picked from commit a53e947) Co-authored-by: Harshil Sharma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rajat-Dabade You should create a <HiddenCardCount>
component. Then in the various views, you can simply call that component. This will encapsulate that functionality. Also, we should check the cloud license first, so we don't do anything else if there are no limits. An on-premise server should not ever need to call getHiddenCards
.
Let me know if any of my comments need further explanation. Thanks
webapp/src/components/kanban/__snapshots__/kanban.test.tsx.snap
Outdated
Show resolved
Hide resolved
@@ -80,6 +80,7 @@ describe('src/component/kanban/kanban', () => { | |||
comments: { | |||
comments: {}, | |||
}, | |||
boards: {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test for displaying the component.
@Rajat-Dabade - Could you also add screen shots to the PR. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rajat-Dabade - Looking good. There is one file that no longer needs changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying the changes @Rajat-Dabade! LGTM! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for not noticing this before, but since you moved the retrieval of hidden cards into workspace.tsx
, I noticed that you don't need the HiddenCards (Cards[]) at all. You only use the Len of that array. So, I would suggest changing the HIddenCards
property from a Card[] to HIddenCardsCount
as an Int. Defaulting the property to 0, will allow you to not need to change the test code as well.
Let me know if I missed where the actually cards are needed. Also, we should be aware of performance implications for non-limited installations and wrap those with checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good @Rajat-Dabade! small note re: updating the i18n file(s) and it looks like there's a couple merge conflicts, but otherwise LGTM after addressing that
/update-branch |
* Shows "(Deleted User)" instead of UUID when user not found (mattermost-community#2354) (mattermost-community#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * mattermost-communityGH-2212 - Update global link on board (mattermost-community#2492) (mattermost-community#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * mattermost-communityGH-2387 - Fixing link in comments (mattermost-community#2480) (mattermost-community#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (mattermost-community#2468) * Fixed a bug where images of the welcome board were not copied over. (mattermost-community#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * mattermost-communityGH-2496 - Updating board title truncation issue (mattermost-community#2497) (mattermost-community#2503) (cherry picked from commit f9cef8e) Co-authored-by: Asaad Mahmood <[email protected]> * set min-height on empty date to allow click (mattermost-community#2466) (mattermost-community#2504) (cherry picked from commit 20fe19a) Co-authored-by: Scott Bishel <[email protected]> * Fix problem with viewId 0 in the URL (mattermost-community#2474) (mattermost-community#2510) (cherry picked from commit 4cb3a0f) Co-authored-by: Jesús Espino <[email protected]> * don't display temlate page if readonly and access revoked (mattermost-community#2499) (mattermost-community#2515) (cherry picked from commit 61f1a3c) Co-authored-by: Scott Bishel <[email protected]> * mattermost-communityGH-2447 - Updating label overflow (mattermost-community#2479) (mattermost-community#2517) * mattermost-communityGH-2447 - Updating label overflow * Updating labels css (cherry picked from commit 923437c) Co-authored-by: Asaad Mahmood <[email protected]> * mattermost-communityGh-2437 - Updating share board modal (mattermost-community#2511) (mattermost-community#2522) * mattermost-communityGh-2437 - Updating share board modal * Updating test * Updating card dialog and test * Updating comment list (cherry picked from commit 50ded69) Co-authored-by: Asaad Mahmood <[email protected]> * updated/synced prior PR (mattermost-community#2509) (mattermost-community#2523) * updated/synced prior PR * add title back for cypress tests * update unit test for cypress fix * move to function Co-authored-by: Mattermod <[email protected]> (cherry picked from commit 5b309e8) Co-authored-by: Scott Bishel <[email protected]> * modify error page redirects (mattermost-community#2518) (mattermost-community#2532) (cherry picked from commit 84a3f8f) Co-authored-by: Doug Lauder <[email protected]> * Dismiss tour from overlay (mattermost-community#2525) (mattermost-community#2531) * Shows "(Deleted User)" instead of UUID when user not found (mattermost-community#2354) (mattermost-community#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * Added ability to dismiss tour from overlay * mattermost-communityGH-2212 - Update global link on board (mattermost-community#2492) (mattermost-community#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * mattermost-communityGH-2387 - Fixing link in comments (mattermost-community#2480) (mattermost-community#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (mattermost-community#2468) * Fixed a bug where images of the welcome board were not copied over. (mattermost-community#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * Fixed intended behavio * lint fixes * Fixed tests * Fixed tests Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Mattermod <[email protected]> (cherry picked from commit a53e947) Co-authored-by: Harshil Sharma <[email protected]> * Updated Mac what's new for v0.15 * Done with the frontend for limited card count * Updated the code and done with the unit test case * Updated the code according to the review comment and fixed the test cases and ES lints issue * Fixed the import for css file * Changes made according to review comments, Reverted back whatsnew.txt * Minor changes * Updated the code considering review comments Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Harshil Sharma <[email protected]> Co-authored-by: Scott Bishel <[email protected]> Co-authored-by: Jesús Espino <[email protected]> Co-authored-by: Doug Lauder <[email protected]> Co-authored-by: Chen-I Lim <[email protected]> Co-authored-by: Mattermod <[email protected]>
* Shows "(Deleted User)" instead of UUID when user not found (mattermost-community#2354) (mattermost-community#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * mattermost-communityGH-2212 - Update global link on board (mattermost-community#2492) (mattermost-community#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * mattermost-communityGH-2387 - Fixing link in comments (mattermost-community#2480) (mattermost-community#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (mattermost-community#2468) * Fixed a bug where images of the welcome board were not copied over. (mattermost-community#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * mattermost-communityGH-2496 - Updating board title truncation issue (mattermost-community#2497) (mattermost-community#2503) (cherry picked from commit f9cef8e) Co-authored-by: Asaad Mahmood <[email protected]> * set min-height on empty date to allow click (mattermost-community#2466) (mattermost-community#2504) (cherry picked from commit 20fe19a) Co-authored-by: Scott Bishel <[email protected]> * Fix problem with viewId 0 in the URL (mattermost-community#2474) (mattermost-community#2510) (cherry picked from commit 4cb3a0f) Co-authored-by: Jesús Espino <[email protected]> * don't display temlate page if readonly and access revoked (mattermost-community#2499) (mattermost-community#2515) (cherry picked from commit 61f1a3c) Co-authored-by: Scott Bishel <[email protected]> * mattermost-communityGH-2447 - Updating label overflow (mattermost-community#2479) (mattermost-community#2517) * mattermost-communityGH-2447 - Updating label overflow * Updating labels css (cherry picked from commit 923437c) Co-authored-by: Asaad Mahmood <[email protected]> * mattermost-communityGh-2437 - Updating share board modal (mattermost-community#2511) (mattermost-community#2522) * mattermost-communityGh-2437 - Updating share board modal * Updating test * Updating card dialog and test * Updating comment list (cherry picked from commit 50ded69) Co-authored-by: Asaad Mahmood <[email protected]> * updated/synced prior PR (mattermost-community#2509) (mattermost-community#2523) * updated/synced prior PR * add title back for cypress tests * update unit test for cypress fix * move to function Co-authored-by: Mattermod <[email protected]> (cherry picked from commit 5b309e8) Co-authored-by: Scott Bishel <[email protected]> * modify error page redirects (mattermost-community#2518) (mattermost-community#2532) (cherry picked from commit 84a3f8f) Co-authored-by: Doug Lauder <[email protected]> * Dismiss tour from overlay (mattermost-community#2525) (mattermost-community#2531) * Shows "(Deleted User)" instead of UUID when user not found (mattermost-community#2354) (mattermost-community#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * Added ability to dismiss tour from overlay * mattermost-communityGH-2212 - Update global link on board (mattermost-community#2492) (mattermost-community#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * mattermost-communityGH-2387 - Fixing link in comments (mattermost-community#2480) (mattermost-community#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (mattermost-community#2468) * Fixed a bug where images of the welcome board were not copied over. (mattermost-community#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * Fixed intended behavio * lint fixes * Fixed tests * Fixed tests Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Mattermod <[email protected]> (cherry picked from commit a53e947) Co-authored-by: Harshil Sharma <[email protected]> * Updated Mac what's new for v0.15 * Done with the frontend for limited card count * Updated the code and done with the unit test case * Updated the code according to the review comment and fixed the test cases and ES lints issue * Fixed the import for css file * Changes made according to review comments, Reverted back whatsnew.txt * Minor changes * Updated the code considering review comments Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Harshil Sharma <[email protected]> Co-authored-by: Scott Bishel <[email protected]> Co-authored-by: Jesús Espino <[email protected]> Co-authored-by: Doug Lauder <[email protected]> Co-authored-by: Chen-I Lim <[email protected]> Co-authored-by: Mattermod <[email protected]>
* Porting the cards limits to main branch * Fixing Issue 3124 (#3162) * Fixing Issue 3124 * Update webapp/src/components/cardLimitNotification.tsx Co-authored-by: Scott Bishel <[email protected]> * Some polishing in the card limit notifications components (#3169) * Adding missing selector * Adding some small missing parts * Fixing some tests type checks adding the roles attribute to the users * Feature to show hidden card count (#3094) * Shows "(Deleted User)" instead of UUID when user not found (#2354) (#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * GH-2212 - Update global link on board (#2492) (#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * GH-2387 - Fixing link in comments (#2480) (#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (#2468) * Fixed a bug where images of the welcome board were not copied over. (#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * GH-2496 - Updating board title truncation issue (#2497) (#2503) (cherry picked from commit f9cef8e) Co-authored-by: Asaad Mahmood <[email protected]> * set min-height on empty date to allow click (#2466) (#2504) (cherry picked from commit 20fe19a) Co-authored-by: Scott Bishel <[email protected]> * Fix problem with viewId 0 in the URL (#2474) (#2510) (cherry picked from commit 4cb3a0f) Co-authored-by: Jesús Espino <[email protected]> * don't display temlate page if readonly and access revoked (#2499) (#2515) (cherry picked from commit 61f1a3c) Co-authored-by: Scott Bishel <[email protected]> * GH-2447 - Updating label overflow (#2479) (#2517) * GH-2447 - Updating label overflow * Updating labels css (cherry picked from commit 923437c) Co-authored-by: Asaad Mahmood <[email protected]> * Gh-2437 - Updating share board modal (#2511) (#2522) * Gh-2437 - Updating share board modal * Updating test * Updating card dialog and test * Updating comment list (cherry picked from commit 50ded69) Co-authored-by: Asaad Mahmood <[email protected]> * updated/synced prior PR (#2509) (#2523) * updated/synced prior PR * add title back for cypress tests * update unit test for cypress fix * move to function Co-authored-by: Mattermod <[email protected]> (cherry picked from commit 5b309e8) Co-authored-by: Scott Bishel <[email protected]> * modify error page redirects (#2518) (#2532) (cherry picked from commit 84a3f8f) Co-authored-by: Doug Lauder <[email protected]> * Dismiss tour from overlay (#2525) (#2531) * Shows "(Deleted User)" instead of UUID when user not found (#2354) (#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * Added ability to dismiss tour from overlay * GH-2212 - Update global link on board (#2492) (#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * GH-2387 - Fixing link in comments (#2480) (#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (#2468) * Fixed a bug where images of the welcome board were not copied over. (#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * Fixed intended behavio * lint fixes * Fixed tests * Fixed tests Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Mattermod <[email protected]> (cherry picked from commit a53e947) Co-authored-by: Harshil Sharma <[email protected]> * Updated Mac what's new for v0.15 * Done with the frontend for limited card count * Updated the code and done with the unit test case * Updated the code according to the review comment and fixed the test cases and ES lints issue * Fixed the import for css file * Changes made according to review comments, Reverted back whatsnew.txt * Minor changes * Updated the code considering review comments Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Harshil Sharma <[email protected]> Co-authored-by: Scott Bishel <[email protected]> Co-authored-by: Jesús Espino <[email protected]> Co-authored-by: Doug Lauder <[email protected]> Co-authored-by: Chen-I Lim <[email protected]> Co-authored-by: Mattermod <[email protected]> * Fixing some tests * Fixing tests * Fixing some compilation errors * More types error fixes * Fixing eslint * Fixing a typing problem * Updating snapshots * Fixing two small problems * Removing unneeded scss empty file * fixing jest test Co-authored-by: Scott Bishel <[email protected]> Co-authored-by: Rajat Dabade <[email protected]> Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Harshil Sharma <[email protected]> Co-authored-by: Doug Lauder <[email protected]> Co-authored-by: Chen-I Lim <[email protected]> Co-authored-by: Mattermod <[email protected]>
This PR will add a feature to show the hidden card count with the label
Cards Hidden