Shows "(Deleted User)" instead of UUID when user not found #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string.
|
Hello @akkivasu, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
akkivasu
requested review from
wiggin77 and
chenilim
and removed request for
a team
akkivasu
changed the title
|
/check-cla |
wiggin77
added
1: PM Review
|
@akkivasu @wiggin77 Agreed that showing the username would be more meaningful than "(Deleted User)", but would be even better if we could display something like "username (Deleted User)", to provide more helpful information. Simply displaying "(Deleted User)" is still better than our current experience and could be a good first step towards showing it in combination with the username, so I'm okay with what we have here as long as we can iterate on it. cc @asaadmahmood @chenilim |
|
Thanks @akkivasu! Agree this is a step in the right direction. I think we can take this as is and I propose filing a separate card or issue to track storing the user name with the user. There are important corner cases to consider for that, e.g. that the authors of cards don't get spoofed. If we were to display the "fallback / unverified" user name, it should be indicated as such. |
wiggin77
reviewed
Feb 23, 2022
server/services/store/mattermostauthlayer/mattermostauthlayer.go
Outdated
Show resolved
Hide resolved
wiggin77
approved these changes
Feb 23, 2022
sbishel
requested changes
Mar 2, 2022
| @@ -434,7 +434,8 @@ func (s *MattermostAuthLayer) userWorkspacesFromRows(rows *sql.Rows) ([]model.Us | |||
|
|
|||
| for _, userID := range userIDs { | |||
| user, exists := users[userID] | |||
| username := userID | |||
| // Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found | |||
| username := "(Deleted User)" | |||
There was a problem hiding this comment.
This should use intl.Format() so it will be translated.
|
Actually, @wiggin77 pointed out, we do not yet have translations on the server side. Accepting this PR as is for now. |
sbishel
approved these changes
Mar 3, 2022
sbishel
added
CherryPick/Approved
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/focalboard
that referenced
this pull request
Mar 3, 2022
…t-community#2354) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918)
mattermod
added
the
CherryPick/Done
mattermod
removed
the
CherryPick/Approved
sbishel
pushed a commit
that referenced
this pull request
Mar 4, 2022
…2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]>
sbishel
pushed a commit
that referenced
this pull request
Mar 11, 2022
* Shows "(Deleted User)" instead of UUID when user not found (#2354) (#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * Added ability to dismiss tour from overlay * GH-2212 - Update global link on board (#2492) (#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * GH-2387 - Fixing link in comments (#2480) (#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (#2468) * Fixed a bug where images of the welcome board were not copied over. (#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * Fixed intended behavio * lint fixes * Fixed tests * Fixed tests Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Mattermod <[email protected]>
mattermost-build
pushed a commit
to mattermost-build/focalboard
that referenced
this pull request
Mar 11, 2022
* Shows "(Deleted User)" instead of UUID when user not found (mattermost-community#2354) (mattermost-community#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * Added ability to dismiss tour from overlay * mattermost-communityGH-2212 - Update global link on board (mattermost-community#2492) (mattermost-community#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * mattermost-communityGH-2387 - Fixing link in comments (mattermost-community#2480) (mattermost-community#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (mattermost-community#2468) * Fixed a bug where images of the welcome board were not copied over. (mattermost-community#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * Fixed intended behavio * lint fixes * Fixed tests * Fixed tests Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Mattermod <[email protected]> (cherry picked from commit a53e947)
sbishel
pushed a commit
that referenced
this pull request
Mar 11, 2022
* Shows "(Deleted User)" instead of UUID when user not found (#2354) (#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * Added ability to dismiss tour from overlay * GH-2212 - Update global link on board (#2492) (#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * GH-2387 - Fixing link in comments (#2480) (#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (#2468) * Fixed a bug where images of the welcome board were not copied over. (#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * Fixed intended behavio * lint fixes * Fixed tests * Fixed tests Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Mattermod <[email protected]> (cherry picked from commit a53e947) Co-authored-by: Harshil Sharma <[email protected]>
sbishel
added a commit
that referenced
this pull request
May 27, 2022
* Shows "(Deleted User)" instead of UUID when user not found (#2354) (#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * GH-2212 - Update global link on board (#2492) (#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * GH-2387 - Fixing link in comments (#2480) (#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (#2468) * Fixed a bug where images of the welcome board were not copied over. (#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * GH-2496 - Updating board title truncation issue (#2497) (#2503) (cherry picked from commit f9cef8e) Co-authored-by: Asaad Mahmood <[email protected]> * set min-height on empty date to allow click (#2466) (#2504) (cherry picked from commit 20fe19a) Co-authored-by: Scott Bishel <[email protected]> * Fix problem with viewId 0 in the URL (#2474) (#2510) (cherry picked from commit 4cb3a0f) Co-authored-by: Jesús Espino <[email protected]> * don't display temlate page if readonly and access revoked (#2499) (#2515) (cherry picked from commit 61f1a3c) Co-authored-by: Scott Bishel <[email protected]> * GH-2447 - Updating label overflow (#2479) (#2517) * GH-2447 - Updating label overflow * Updating labels css (cherry picked from commit 923437c) Co-authored-by: Asaad Mahmood <[email protected]> * Gh-2437 - Updating share board modal (#2511) (#2522) * Gh-2437 - Updating share board modal * Updating test * Updating card dialog and test * Updating comment list (cherry picked from commit 50ded69) Co-authored-by: Asaad Mahmood <[email protected]> * updated/synced prior PR (#2509) (#2523) * updated/synced prior PR * add title back for cypress tests * update unit test for cypress fix * move to function Co-authored-by: Mattermod <[email protected]> (cherry picked from commit 5b309e8) Co-authored-by: Scott Bishel <[email protected]> * modify error page redirects (#2518) (#2532) (cherry picked from commit 84a3f8f) Co-authored-by: Doug Lauder <[email protected]> * Dismiss tour from overlay (#2525) (#2531) * Shows "(Deleted User)" instead of UUID when user not found (#2354) (#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * Added ability to dismiss tour from overlay * GH-2212 - Update global link on board (#2492) (#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * GH-2387 - Fixing link in comments (#2480) (#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (#2468) * Fixed a bug where images of the welcome board were not copied over. (#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * Fixed intended behavio * lint fixes * Fixed tests * Fixed tests Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Mattermod <[email protected]> (cherry picked from commit a53e947) Co-authored-by: Harshil Sharma <[email protected]> * Updated Mac what's new for v0.15 * Done with the frontend for limited card count * Updated the code and done with the unit test case * Updated the code according to the review comment and fixed the test cases and ES lints issue * Fixed the import for css file * Changes made according to review comments, Reverted back whatsnew.txt * Minor changes * Updated the code considering review comments Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Harshil Sharma <[email protected]> Co-authored-by: Scott Bishel <[email protected]> Co-authored-by: Jesús Espino <[email protected]> Co-authored-by: Doug Lauder <[email protected]> Co-authored-by: Chen-I Lim <[email protected]> Co-authored-by: Mattermod <[email protected]>
jespino
added a commit
to jespino/focalboard
that referenced
this pull request
Jun 9, 2022
* Shows "(Deleted User)" instead of UUID when user not found (mattermost-community#2354) (mattermost-community#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * mattermost-communityGH-2212 - Update global link on board (mattermost-community#2492) (mattermost-community#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * mattermost-communityGH-2387 - Fixing link in comments (mattermost-community#2480) (mattermost-community#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (mattermost-community#2468) * Fixed a bug where images of the welcome board were not copied over. (mattermost-community#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * mattermost-communityGH-2496 - Updating board title truncation issue (mattermost-community#2497) (mattermost-community#2503) (cherry picked from commit f9cef8e) Co-authored-by: Asaad Mahmood <[email protected]> * set min-height on empty date to allow click (mattermost-community#2466) (mattermost-community#2504) (cherry picked from commit 20fe19a) Co-authored-by: Scott Bishel <[email protected]> * Fix problem with viewId 0 in the URL (mattermost-community#2474) (mattermost-community#2510) (cherry picked from commit 4cb3a0f) Co-authored-by: Jesús Espino <[email protected]> * don't display temlate page if readonly and access revoked (mattermost-community#2499) (mattermost-community#2515) (cherry picked from commit 61f1a3c) Co-authored-by: Scott Bishel <[email protected]> * mattermost-communityGH-2447 - Updating label overflow (mattermost-community#2479) (mattermost-community#2517) * mattermost-communityGH-2447 - Updating label overflow * Updating labels css (cherry picked from commit 923437c) Co-authored-by: Asaad Mahmood <[email protected]> * mattermost-communityGh-2437 - Updating share board modal (mattermost-community#2511) (mattermost-community#2522) * mattermost-communityGh-2437 - Updating share board modal * Updating test * Updating card dialog and test * Updating comment list (cherry picked from commit 50ded69) Co-authored-by: Asaad Mahmood <[email protected]> * updated/synced prior PR (mattermost-community#2509) (mattermost-community#2523) * updated/synced prior PR * add title back for cypress tests * update unit test for cypress fix * move to function Co-authored-by: Mattermod <[email protected]> (cherry picked from commit 5b309e8) Co-authored-by: Scott Bishel <[email protected]> * modify error page redirects (mattermost-community#2518) (mattermost-community#2532) (cherry picked from commit 84a3f8f) Co-authored-by: Doug Lauder <[email protected]> * Dismiss tour from overlay (mattermost-community#2525) (mattermost-community#2531) * Shows "(Deleted User)" instead of UUID when user not found (mattermost-community#2354) (mattermost-community#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * Added ability to dismiss tour from overlay * mattermost-communityGH-2212 - Update global link on board (mattermost-community#2492) (mattermost-community#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * mattermost-communityGH-2387 - Fixing link in comments (mattermost-community#2480) (mattermost-community#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (mattermost-community#2468) * Fixed a bug where images of the welcome board were not copied over. (mattermost-community#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * Fixed intended behavio * lint fixes * Fixed tests * Fixed tests Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Mattermod <[email protected]> (cherry picked from commit a53e947) Co-authored-by: Harshil Sharma <[email protected]> * Updated Mac what's new for v0.15 * Done with the frontend for limited card count * Updated the code and done with the unit test case * Updated the code according to the review comment and fixed the test cases and ES lints issue * Fixed the import for css file * Changes made according to review comments, Reverted back whatsnew.txt * Minor changes * Updated the code considering review comments Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Harshil Sharma <[email protected]> Co-authored-by: Scott Bishel <[email protected]> Co-authored-by: Jesús Espino <[email protected]> Co-authored-by: Doug Lauder <[email protected]> Co-authored-by: Chen-I Lim <[email protected]> Co-authored-by: Mattermod <[email protected]>
jespino
added a commit
to jespino/focalboard
that referenced
this pull request
Jun 15, 2022
* Shows "(Deleted User)" instead of UUID when user not found (mattermost-community#2354) (mattermost-community#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * mattermost-communityGH-2212 - Update global link on board (mattermost-community#2492) (mattermost-community#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * mattermost-communityGH-2387 - Fixing link in comments (mattermost-community#2480) (mattermost-community#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (mattermost-community#2468) * Fixed a bug where images of the welcome board were not copied over. (mattermost-community#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * mattermost-communityGH-2496 - Updating board title truncation issue (mattermost-community#2497) (mattermost-community#2503) (cherry picked from commit f9cef8e) Co-authored-by: Asaad Mahmood <[email protected]> * set min-height on empty date to allow click (mattermost-community#2466) (mattermost-community#2504) (cherry picked from commit 20fe19a) Co-authored-by: Scott Bishel <[email protected]> * Fix problem with viewId 0 in the URL (mattermost-community#2474) (mattermost-community#2510) (cherry picked from commit 4cb3a0f) Co-authored-by: Jesús Espino <[email protected]> * don't display temlate page if readonly and access revoked (mattermost-community#2499) (mattermost-community#2515) (cherry picked from commit 61f1a3c) Co-authored-by: Scott Bishel <[email protected]> * mattermost-communityGH-2447 - Updating label overflow (mattermost-community#2479) (mattermost-community#2517) * mattermost-communityGH-2447 - Updating label overflow * Updating labels css (cherry picked from commit 923437c) Co-authored-by: Asaad Mahmood <[email protected]> * mattermost-communityGh-2437 - Updating share board modal (mattermost-community#2511) (mattermost-community#2522) * mattermost-communityGh-2437 - Updating share board modal * Updating test * Updating card dialog and test * Updating comment list (cherry picked from commit 50ded69) Co-authored-by: Asaad Mahmood <[email protected]> * updated/synced prior PR (mattermost-community#2509) (mattermost-community#2523) * updated/synced prior PR * add title back for cypress tests * update unit test for cypress fix * move to function Co-authored-by: Mattermod <[email protected]> (cherry picked from commit 5b309e8) Co-authored-by: Scott Bishel <[email protected]> * modify error page redirects (mattermost-community#2518) (mattermost-community#2532) (cherry picked from commit 84a3f8f) Co-authored-by: Doug Lauder <[email protected]> * Dismiss tour from overlay (mattermost-community#2525) (mattermost-community#2531) * Shows "(Deleted User)" instead of UUID when user not found (mattermost-community#2354) (mattermost-community#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * Added ability to dismiss tour from overlay * mattermost-communityGH-2212 - Update global link on board (mattermost-community#2492) (mattermost-community#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * mattermost-communityGH-2387 - Fixing link in comments (mattermost-community#2480) (mattermost-community#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (mattermost-community#2468) * Fixed a bug where images of the welcome board were not copied over. (mattermost-community#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * Fixed intended behavio * lint fixes * Fixed tests * Fixed tests Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Mattermod <[email protected]> (cherry picked from commit a53e947) Co-authored-by: Harshil Sharma <[email protected]> * Updated Mac what's new for v0.15 * Done with the frontend for limited card count * Updated the code and done with the unit test case * Updated the code according to the review comment and fixed the test cases and ES lints issue * Fixed the import for css file * Changes made according to review comments, Reverted back whatsnew.txt * Minor changes * Updated the code considering review comments Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Harshil Sharma <[email protected]> Co-authored-by: Scott Bishel <[email protected]> Co-authored-by: Jesús Espino <[email protected]> Co-authored-by: Doug Lauder <[email protected]> Co-authored-by: Chen-I Lim <[email protected]> Co-authored-by: Mattermod <[email protected]>
jespino
added a commit
that referenced
this pull request
Jun 20, 2022
* Porting the cards limits to main branch * Fixing Issue 3124 (#3162) * Fixing Issue 3124 * Update webapp/src/components/cardLimitNotification.tsx Co-authored-by: Scott Bishel <[email protected]> * Some polishing in the card limit notifications components (#3169) * Adding missing selector * Adding some small missing parts * Fixing some tests type checks adding the roles attribute to the users * Feature to show hidden card count (#3094) * Shows "(Deleted User)" instead of UUID when user not found (#2354) (#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * GH-2212 - Update global link on board (#2492) (#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * GH-2387 - Fixing link in comments (#2480) (#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (#2468) * Fixed a bug where images of the welcome board were not copied over. (#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * GH-2496 - Updating board title truncation issue (#2497) (#2503) (cherry picked from commit f9cef8e) Co-authored-by: Asaad Mahmood <[email protected]> * set min-height on empty date to allow click (#2466) (#2504) (cherry picked from commit 20fe19a) Co-authored-by: Scott Bishel <[email protected]> * Fix problem with viewId 0 in the URL (#2474) (#2510) (cherry picked from commit 4cb3a0f) Co-authored-by: Jesús Espino <[email protected]> * don't display temlate page if readonly and access revoked (#2499) (#2515) (cherry picked from commit 61f1a3c) Co-authored-by: Scott Bishel <[email protected]> * GH-2447 - Updating label overflow (#2479) (#2517) * GH-2447 - Updating label overflow * Updating labels css (cherry picked from commit 923437c) Co-authored-by: Asaad Mahmood <[email protected]> * Gh-2437 - Updating share board modal (#2511) (#2522) * Gh-2437 - Updating share board modal * Updating test * Updating card dialog and test * Updating comment list (cherry picked from commit 50ded69) Co-authored-by: Asaad Mahmood <[email protected]> * updated/synced prior PR (#2509) (#2523) * updated/synced prior PR * add title back for cypress tests * update unit test for cypress fix * move to function Co-authored-by: Mattermod <[email protected]> (cherry picked from commit 5b309e8) Co-authored-by: Scott Bishel <[email protected]> * modify error page redirects (#2518) (#2532) (cherry picked from commit 84a3f8f) Co-authored-by: Doug Lauder <[email protected]> * Dismiss tour from overlay (#2525) (#2531) * Shows "(Deleted User)" instead of UUID when user not found (#2354) (#2465) * Shows "(Deleted User)" instead of long, unreadable UUID in case the user is not found In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string. * Update server/services/store/mattermostauthlayer/mattermostauthlayer.go Co-authored-by: Doug Lauder <[email protected]> (cherry picked from commit 6881918) Co-authored-by: Akshay Vasudeva Rao <[email protected]> * Update CHANGELOG.md for v0.15 Added one more merged PR to the list * Added ability to dismiss tour from overlay * GH-2212 - Update global link on board (#2492) (#2495) (cherry picked from commit 49df41f) Co-authored-by: Asaad Mahmood <[email protected]> * GH-2387 - Fixing link in comments (#2480) (#2498) (cherry picked from commit 5e2cf0b) Co-authored-by: Asaad Mahmood <[email protected]> * Addead feature to start product tour on using the welcome template (#2468) * Fixed a bug where images of the welcome board were not copied over. (#2453) * Fixed a buig where images of welcome board were not copied over * Lint fixes * Fixed test * Fixed test * Fixed intended behavio * lint fixes * Fixed tests * Fixed tests Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Mattermod <[email protected]> (cherry picked from commit a53e947) Co-authored-by: Harshil Sharma <[email protected]> * Updated Mac what's new for v0.15 * Done with the frontend for limited card count * Updated the code and done with the unit test case * Updated the code according to the review comment and fixed the test cases and ES lints issue * Fixed the import for css file * Changes made according to review comments, Reverted back whatsnew.txt * Minor changes * Updated the code considering review comments Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Harshil Sharma <[email protected]> Co-authored-by: Scott Bishel <[email protected]> Co-authored-by: Jesús Espino <[email protected]> Co-authored-by: Doug Lauder <[email protected]> Co-authored-by: Chen-I Lim <[email protected]> Co-authored-by: Mattermod <[email protected]> * Fixing some tests * Fixing tests * Fixing some compilation errors * More types error fixes * Fixing eslint * Fixing a typing problem * Updating snapshots * Fixing two small problems * Removing unneeded scss empty file * fixing jest test Co-authored-by: Scott Bishel <[email protected]> Co-authored-by: Rajat Dabade <[email protected]> Co-authored-by: Mattermost Build <[email protected]> Co-authored-by: Akshay Vasudeva Rao <[email protected]> Co-authored-by: Winson Wu <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Harshil Sharma <[email protected]> Co-authored-by: Doug Lauder <[email protected]> Co-authored-by: Chen-I Lim <[email protected]> Co-authored-by: Mattermod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a user is not found, at present unreadable and long UUIDs are shown which kill the look and feel of the application. This patch replaces the UUID with a more explanatory string.
Summary
Ticket Link