-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Draft: Migrate to OpenTelemetry tracing #13400
Draft: Migrate to OpenTelemetry tracing #13400
Commits on Jul 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0cc610e - Browse repository at this point
Copy the full SHA 0cc610eView commit details
Commits on Jul 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2fe6911 - Browse repository at this point
Copy the full SHA 2fe6911View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6984cef - Browse repository at this point
Copy the full SHA 6984cefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6406fd5 - Browse repository at this point
Copy the full SHA 6406fd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2428172 - Browse repository at this point
Copy the full SHA 2428172View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d7a2b9 - Browse repository at this point
Copy the full SHA 0d7a2b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e1de86 - Browse repository at this point
Copy the full SHA 9e1de86View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6c3b22 - Browse repository at this point
Copy the full SHA f6c3b22View commit details
Commits on Jul 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3a25996 - Browse repository at this point
Copy the full SHA 3a25996View commit details
Commits on Jul 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1b0840e - Browse repository at this point
Copy the full SHA 1b0840eView commit details -
``` Invalid type StreamToken for attribute value. Expected one of ['bool', 'str', 'bytes', 'int', 'float'] or a sequence of those types ``` Had to add a few more logs to find this instance since the warning doens't give much info where I am setting this invalid attribute. This was good enough to find it in the code. ``` BoundedAttributes __setitem__ key=since_token value=StreamToken(room_key=RoomStreamToken(topological=None, stream=1787, instance_map=frozendict.frozendict({})), presence_key=481272, typing_key=0, receipt_key=340, account_data_key=1233, push_rules_key=8, to_device_key=57, device_list_key=199, groups_key=0) BoundedAttributes __setitem__ key=now_token value=StreamToken(room_key=RoomStreamToken(topological=None, stream=1787, instance_map=frozendict.frozendict({})), presence_key=481287, typing_key=0, receipt_key=340, account_data_key=1233, push_rules_key=8, to_device_key=57, device_list_key=199, groups_key=0) BoundedAttributes __setitem__ key=token value=StreamToken(room_key=RoomStreamToken(topological=None, stream=1787, instance_map=frozendict.frozendict({})), presence_key=481291, typing_key=0, receipt_key=340, account_data_key=1237, push_rules_key=8, to_device_key=57, device_list_key=199, groups_key=0) ```
Configuration menu - View commit details
-
Copy full SHA for 1d208fa - Browse repository at this point
Copy the full SHA 1d208faView commit details -
Fix using wrong type of context (
Context
vsSpanContext
)Fix error: ``` AttributeError: 'SpanContext' object has no attribute 'get' ``` `Context`: ``` {'current-span-1a226c96-a5db-4412-bcaa-1fdd34213c5c': _Span(name="sendToDevice", context=SpanContext(trace_id=0x5d2dcc3fdc8205046d60a5cd18672ac6, span_id=0x715c736ff5f4d208, trace_flags=0x01, trace_state=[], is_remote=False))} ``` `SpanContext`: ``` SpanContext(trace_id=0xf7cd9d058b7b76f364bdd649c4ba7b8a, span_id=0x287ce71bac31bfc4, trace_flags=0x01, trace_state=[], is_remote=False) ```
Configuration menu - View commit details
-
Copy full SHA for 2011ac2 - Browse repository at this point
Copy the full SHA 2011ac2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19d20b5 - Browse repository at this point
Copy the full SHA 19d20b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 786dd9b - Browse repository at this point
Copy the full SHA 786dd9bView commit details
Commits on Jul 30, 2022
-
Easier to follow local vs remote span tracing
The `incoming-federation-request` vs `process-federation_request` was first introduced in #11870 - Span for remote trace: `incoming-federation-request` - `child_of` reference: `origin_span_context` - `follows_from` reference: `servlet_span` - Span for local trace: `process-federation-request` - `child_of` reference: `servlet_span` (by the nature of it being active) - `follows_from` reference: `incoming-federation-request`
Configuration menu - View commit details
-
Copy full SHA for 7c135b9 - Browse repository at this point
Copy the full SHA 7c135b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d29a4af - Browse repository at this point
Copy the full SHA d29a4afView commit details -
Working second test although it's a bit pointless testing whether ope…
…ntelemetry works
Configuration menu - View commit details
-
Copy full SHA for 041acdf - Browse repository at this point
Copy the full SHA 041acdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for d848156 - Browse repository at this point
Copy the full SHA d848156View commit details -
Configuration menu - View commit details
-
Copy full SHA for 070195a - Browse repository at this point
Copy the full SHA 070195aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7772f50 - Browse repository at this point
Copy the full SHA 7772f50View commit details
Commits on Aug 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 322da51 - Browse repository at this point
Copy the full SHA 322da51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33fd24e - Browse repository at this point
Copy the full SHA 33fd24eView commit details -
Implement start_active_span_from_edu for OTEL
AFAICT, this never worked before because everything was serialized into `content["org.matrix.opentracing_context"]` but `start_active_span_from_edu` read from `content["opentracing"]`. See #5852 (comment) Do we even still want this?
Configuration menu - View commit details
-
Copy full SHA for a9fb504 - Browse repository at this point
Copy the full SHA a9fb504View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e902b8 - Browse repository at this point
Copy the full SHA 8e902b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00be06c - Browse repository at this point
Copy the full SHA 00be06cView commit details
Commits on Aug 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6255a1a - Browse repository at this point
Copy the full SHA 6255a1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b3cdbad - Browse repository at this point
Copy the full SHA b3cdbadView commit details -
Configuration menu - View commit details
-
Copy full SHA for d15fa45 - Browse repository at this point
Copy the full SHA d15fa45View commit details -
Revert "Non-working try baggage to inherit force tracing/sampling"
This reverts commit d15fa45.
Configuration menu - View commit details
-
Copy full SHA for 6bb7cb7 - Browse repository at this point
Copy the full SHA 6bb7cb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbd9005 - Browse repository at this point
Copy the full SHA dbd9005View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f93ec8 - Browse repository at this point
Copy the full SHA 0f93ec8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36d6648 - Browse repository at this point
Copy the full SHA 36d6648View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb0e820 - Browse repository at this point
Copy the full SHA fb0e820View commit details -
Configuration menu - View commit details
-
Copy full SHA for b09651a - Browse repository at this point
Copy the full SHA b09651aView commit details -
Configuration menu - View commit details
-
Copy full SHA for da396a2 - Browse repository at this point
Copy the full SHA da396a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad71bc3 - Browse repository at this point
Copy the full SHA ad71bc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59facea - Browse repository at this point
Copy the full SHA 59faceaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d6fcf3 - Browse repository at this point
Copy the full SHA 9d6fcf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcc4220 - Browse repository at this point
Copy the full SHA fcc4220View commit details -
Configuration menu - View commit details
-
Copy full SHA for d72cacf - Browse repository at this point
Copy the full SHA d72cacfView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba4a46a - Browse repository at this point
Copy the full SHA ba4a46aView commit details -
Merge branch 'develop' into madlittlemods/11850-migrate-to-opentelemetry
Conflicts: docs/usage/configuration/config_documentation.md synapse/logging/opentracing.py Got changes from: - https://github.com/matrix-org/synapse/pull/13362/files
Configuration menu - View commit details
-
Copy full SHA for 72c718d - Browse repository at this point
Copy the full SHA 72c718dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c26fa2d - Browse repository at this point
Copy the full SHA c26fa2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5999132 - Browse repository at this point
Copy the full SHA 5999132View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2491665 - Browse repository at this point
Copy the full SHA 2491665View commit details
Commits on Aug 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 16d17f7 - Browse repository at this point
Copy the full SHA 16d17f7View commit details -
Use latested Twisted from source to fix contextvar issues causing OTE…
…L `Failed to detach context` errors See #13400 (comment)
Configuration menu - View commit details
-
Copy full SHA for b6f5665 - Browse repository at this point
Copy the full SHA b6f5665View commit details -
Merge branch 'develop' into madlittlemods/11850-migrate-to-opentelemetry
Conflicts: docs/usage/configuration/config_documentation.md synapse/api/auth.py
Configuration menu - View commit details
-
Copy full SHA for 699dad0 - Browse repository at this point
Copy the full SHA 699dad0View commit details -
Update treq to match minimum Twisted Python versions
Hopefully fix https://github.com/matrix-org/synapse/runs/7645395562?check_suite_focus=true#step:7:6727 ``` builtins.ImportError: cannot import name '_PY3' from 'twisted.python.compat' (unknown location) ```
Configuration menu - View commit details
-
Copy full SHA for 270db42 - Browse repository at this point
Copy the full SHA 270db42View commit details -
Revert "Update treq to match minimum Twisted Python versions"
This reverts commit 270db42.
Configuration menu - View commit details
-
Copy full SHA for f5da762 - Browse repository at this point
Copy the full SHA f5da762View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccd4752 - Browse repository at this point
Copy the full SHA ccd4752View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7166a0 - Browse repository at this point
Copy the full SHA d7166a0View commit details
Commits on Aug 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7566375 - Browse repository at this point
Copy the full SHA 7566375View commit details
Commits on Aug 9, 2022
-
Merge branch 'develop' into madlittlemods/11850-migrate-to-opentelemetry
Conflicts: synapse/logging/opentracing.py tests/logging/test_opentracing.py
Configuration menu - View commit details
-
Copy full SHA for 7024d7b - Browse repository at this point
Copy the full SHA 7024d7bView commit details
Commits on Aug 18, 2022
-
Merge branch 'develop' into madlittlemods/11850-migrate-to-opentelemetry
Conflicts: poetry.lock synapse/federation/federation_client.py synapse/federation/federation_server.py synapse/handlers/federation.py synapse/handlers/federation_event.py synapse/logging/opentracing.py synapse/rest/client/room.py synapse/storage/controllers/persist_events.py synapse/storage/controllers/state.py
Configuration menu - View commit details
-
Copy full SHA for 8def7e4 - Browse repository at this point
Copy the full SHA 8def7e4View commit details
Commits on Sep 9, 2022
-
Merge branch 'develop' into madlittlemods/11850-migrate-to-opentelemetry
Conflicts: poetry.lock synapse/api/auth.py synapse/federation/federation_client.py synapse/logging/opentracing.py synapse/rest/client/keys.py synapse/rest/client/sendtodevice.py synapse/storage/schema/__init__.py
Configuration menu - View commit details
-
Copy full SHA for 50f0342 - Browse repository at this point
Copy the full SHA 50f0342View commit details -
Configuration menu - View commit details
-
Copy full SHA for f73bc59 - Browse repository at this point
Copy the full SHA f73bc59View commit details -
Configuration menu - View commit details
-
Copy full SHA for a15592d - Browse repository at this point
Copy the full SHA a15592dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32b9d16 - Browse repository at this point
Copy the full SHA 32b9d16View commit details
Commits on Sep 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6c40dfa - Browse repository at this point
Copy the full SHA 6c40dfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad3e324 - Browse repository at this point
Copy the full SHA ad3e324View commit details
Commits on Sep 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 15e242e - Browse repository at this point
Copy the full SHA 15e242eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d730a46 - Browse repository at this point
Copy the full SHA d730a46View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed11237 - Browse repository at this point
Copy the full SHA ed11237View commit details -
Merge branch 'develop' into madlittlemods/11850-migrate-to-opentelemetry
Conflicts: synapse/storage/schema/__init__.py
Configuration menu - View commit details
-
Copy full SHA for 19c6f6e - Browse repository at this point
Copy the full SHA 19c6f6eView commit details -
Hopefully fix problem when OTEL not installed with non recording span
``` Traceback (most recent call last): File "/usr/local/lib/python3.9/site-packages/synapse/http/server.py", line 306, in _async_render_wrapper callback_return = await self._async_render(request) File "/usr/local/lib/python3.9/site-packages/synapse/http/server.py", line 512, in _async_render callback_return = await raw_callback_return File "/usr/local/lib/python3.9/site-packages/synapse/federation/transport/server/_base.py", line 357, in new_func remote_parent_span = create_non_recording_span() File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 502, in create_non_recording_span return opentelemetry.trace.NonRecordingSpan( AttributeError: 'NoneType' object has no attribute 'trace' ```
Configuration menu - View commit details
-
Copy full SHA for b77d49f - Browse repository at this point
Copy the full SHA b77d49fView commit details
Commits on Sep 14, 2022
-
Maybe fix positional argument mismatch for DummyLink
Hopefully fix: ``` File "/home/runner/work/synapse/synapse/synapse/storage/controllers/persist_events.py", line 246, in add_to_queue links=[Link(end_item.tracing_span_context)], builtins.TypeError: __init__() takes 1 positional argument but 2 were given ```
Configuration menu - View commit details
-
Copy full SHA for a027c6e - Browse repository at this point
Copy the full SHA a027c6eView commit details -
Merge branch 'develop' into madlittlemods/11850-migrate-to-opentelemetry
Conflicts: synapse/storage/schema/__init__.py
Configuration menu - View commit details
-
Copy full SHA for 84f91e3 - Browse repository at this point
Copy the full SHA 84f91e3View commit details
Commits on Sep 20, 2022
-
Merge branch 'develop' into madlittlemods/11850-migrate-to-opentelemetry
Conflicts: .github/workflows/tests.yml poetry.lock synapse/storage/schema/__init__.py
Configuration menu - View commit details
-
Copy full SHA for b86869f - Browse repository at this point
Copy the full SHA b86869fView commit details
Commits on Sep 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e4b9898 - Browse repository at this point
Copy the full SHA e4b9898View commit details
Commits on Oct 1, 2022
-
Merge branch 'develop' into madlittlemods/11850-migrate-to-opentelemetry
Conflicts: synapse/handlers/message.py synapse/logging/opentracing.py
Configuration menu - View commit details
-
Copy full SHA for 4a495ac - Browse repository at this point
Copy the full SHA 4a495acView commit details
Commits on Oct 20, 2022
-
Merge branch 'develop' into madlittlemods/11850-migrate-to-opentelemetry
Conflicts: poetry.lock (conflicts not fixed) synapse/handlers/message.py synapse/handlers/relations.py synapse/storage/databases/main/devices.py synapse/storage/schema/__init__.py
Configuration menu - View commit details
-
Copy full SHA for 7d70acd - Browse repository at this point
Copy the full SHA 7d70acdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 627951e - Browse repository at this point
Copy the full SHA 627951eView commit details
Commits on Nov 18, 2022
-
Merge branch 'develop' into madlittlemods/11850-migrate-to-opentelemetry
Conflicts: docs/usage/configuration/config_documentation.md poetry.lock synapse/handlers/message.py synapse/http/server.py synapse/logging/opentracing.py synapse/rest/client/keys.py synapse/rest/client/room.py
Configuration menu - View commit details
-
Copy full SHA for d993cb0 - Browse repository at this point
Copy the full SHA d993cb0View commit details
Commits on Nov 21, 2022
-
Merge branch 'develop' into madlittlemods/11850-migrate-to-opentelemetry
Conflicts: poetry.lock
Configuration menu - View commit details
-
Copy full SHA for 7acb365 - Browse repository at this point
Copy the full SHA 7acb365View commit details