Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

switch from jaeger-client to opentelemetry #11850

Open
richvdh opened this issue Jan 28, 2022 · 3 comments
Open

switch from jaeger-client to opentelemetry #11850

richvdh opened this issue Jan 28, 2022 · 3 comments
Labels
A-Performance Performance, both client-facing and admin-facing T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@richvdh
Copy link
Member

richvdh commented Jan 28, 2022

The jaeger-client library has been deprecated, and security support is due to end in July 2022. The replacement is opentelemetry.

This will require rewriting, or replacing, https://github.com/erikjohnston/rust-jaeger-python-client.

@clokep clokep added T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. A-Performance Performance, both client-facing and admin-facing labels Feb 1, 2022
MadLittleMods added a commit that referenced this issue Jul 26, 2022
@MadLittleMods
Copy link
Contributor

This will require rewriting, or replacing, https://github.com/erikjohnston/rust-jaeger-python-client

Got some more context from @erikjohnston on why we need the Rust exporter and it boils down to using a Python reporter/exporter can easily slow down the rest of Synapse. Python is slower than Rust but also the Python global interpreter lock (GIL) prevents multi-threaded work from being faster (🙇 hopefully not too off)


There is some uncertainty of moving to OpenTelemetry because of drama and unclear from the outside what the current state is of anything. [TODO: any details?]

@MadLittleMods
Copy link
Contributor

There is some uncertainty of moving to OpenTelemetry because of drama and unclear from the outside what the current state is of anything. [TODO: any details?]

This point is no longer relevant. This was touched on in the August backend chapter meeting and turned out to really be of no substance. Perhaps just murmurings when the project was first getting going. But seems like the canonical new choice to go to now.

@yu-re-ka
Copy link

opentracing breaks with asyncio changes in Python 3.11, so now would be a good time to migrate

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Performance Performance, both client-facing and admin-facing T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants