Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Synapse accepts /forget without a request body but this is not meant to be allowed by the specification #16366

Open
reivilibre opened this issue Sep 22, 2023 · 0 comments
Open

Synapse accepts /forget without a request body but this is not meant to be allowed by the specification #16366

reivilibre opened this issue Sep 22, 2023 · 0 comments
Labels
A-Spec-Compliance places where synapse does not conform to the spec O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases

Comments

@reivilibre
Copy link
Contributor

Like all PUT and POST requests other than the media ones (and /logout...), /forget is supposed to take a JSON body, e.g. {} if nothing special is required. Currently Synapse as at v1.92.3 does not require this.

#16365 adds a warning against this.

We should see if any clients are hitting this and then a future version should cut this off completely.
@reivilibre reivilibre added A-Spec-Compliance places where synapse does not conform to the spec Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases labels Sep 22, 2023
This was referenced Sep 22, 2023
Closed
Merged
Open
@clokep clokep added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Oct 25, 2023
@matrixbot matrixbot mentioned this issue Dec 22, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Spec-Compliance places where synapse does not conform to the spec O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clokep @reivilibre