Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty request bodies to /forget calls in TestRoomForget #652

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Add empty request bodies to /forget calls in TestRoomForget #652

merged 2 commits into from
Sep 27, 2023

Conversation

reivilibre
Copy link
Contributor

These are meant to be required but it seems like they are not in practice...

c.f. matrix-org/synapse#16366

@reivilibre reivilibre requested review from a team as code owners September 22, 2023 18:53
@reivilibre reivilibre changed the title Add empty request bodies to /forget calls Add empty request bodies to /forget calls in TestRoomForget Sep 22, 2023
@reivilibre
Copy link
Contributor Author

(ironically it was sending Content-Type: application/json even though they didn't have a request body! Ideally Synapse would not accept these, c.f. matrix-org/synapse#16393)

@reivilibre reivilibre merged commit 6cad09b into main Sep 27, 2023
4 checks passed
@reivilibre reivilibre deleted the rei/room_forget_fix_body branch September 27, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumnerevans sumnerevans sumnerevans approved these changes

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reivilibre @DMRobertson @sumnerevans