Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synapse accepts /forget without a request body but this is not meant to be allowed by the specification #16366

Open
matrixbot opened this issue Dec 21, 2023 · 0 comments
Open

Synapse accepts /forget without a request body but this is not meant to be allowed by the specification #16366

matrixbot opened this issue Dec 21, 2023 · 0 comments
Labels
A-Spec-Compliance O-Uncommon S-Tolerable T-Defect Z-Future-Maintenance

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 21, 2023 •
edited
Loading

This issue has been migrated from #16366.

Like all PUT and POST requests other than the media ones (and /logout...), /forget is supposed to take a JSON body, e.g. {} if nothing special is required. Currently Synapse as at v1.92.3 does not require this.

#16365 adds a warning against this.

We should see if any clients are hitting this and then a future version should cut this off completely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Spec-Compliance O-Uncommon S-Tolerable T-Defect Z-Future-Maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matrixbot