Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling over membership in Gitter historical room jumps calendar around because those events weren't timestamp massaged #182

Closed
MadLittleMods opened this issue Apr 25, 2023 · 1 comment · Fixed by #196
Closed

Scrolling over membership in Gitter historical room jumps calendar around because those events weren't timestamp massaged #182

MadLittleMods opened this issue Apr 25, 2023 · 1 comment · Fixed by #196
Labels
A-archive-room-view The view to look at a room day by day in the archive T-Defect Something isn't working. Bugs, crashes, or other reported issues.
Milestone
Matrix Public Arc...

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Apr 25, 2023 •
edited
Loading

Scrolling over membership in Gitter historical room jumps calendar around because those events weren't timestamp massaged.

.../r/gitter_gitter:gitter.im/date/2015/11/15

In the future, it would be nice to timestamp massage /join membership events (see MSC3998) so we don't have to do this type of ignoring and so the room is more semantic.

Potential solution

Ignore membership events in the IntersectionObserver (because they aren’t timestamp massaged) so you don’t jump around in the calendar
@MadLittleMods MadLittleMods added T-Enhancement New feature or request A-archive-room-view The view to look at a room day by day in the archive labels Apr 25, 2023
@MadLittleMods MadLittleMods added T-Defect Something isn't working. Bugs, crashes, or other reported issues. and removed T-Enhancement New feature or request labels Apr 25, 2023
MadLittleMods added a commit that referenced this issue Apr 27, 2023
@MadLittleMods
Don't jump calendar around for events which appear in the future
02d5529 
Fix #182
@MadLittleMods MadLittleMods mentioned this issue Apr 27, 2023
Merged
@MadLittleMods
Copy link
Contributor Author

MadLittleMods commented Apr 27, 2023 •
edited
Loading

Solved instead by ignoring events which appear in the future compared to timestamp in the URL

Fixed in #196

MadLittleMods added a commit that referenced this issue Apr 27, 2023
@MadLittleMods
Don't jump calendar around for events which appear in the future (#196)
addb021 
Don't jump calendar around for events which appear in the future compared to the timestamp in the URL.

This sort of situation occurs often for Gitter imported historical rooms where we have a bunch of history that is timestamp massaged intermixed with a bunch of join events which we couldn't timestamp massage at the time.

Fix #182
This was referenced Apr 27, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-archive-room-view The view to look at a room day by day in the archive T-Defect Something isn't working. Bugs, crashes, or other reported issues.
Projects
None yet
Milestone
Matrix Public Archive v0.1.0
Development

Successfully merging a pull request may close this issue.

Don't jump calendar around for events which appear in the future matrix-org/matrix-viewer
1 participant
@MadLittleMods