Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent date headers from appearing for rogue events that appear in the future #198

Open
MadLittleMods opened this issue Apr 27, 2023 · 0 comments
Open

Prevent date headers from appearing for rogue events that appear in the future #198

MadLittleMods opened this issue Apr 27, 2023 · 0 comments
Labels
A-archive-room-view The view to look at a room day by day in the archive hydrogen Issues which involve https://github.com/vector-im/hydrogen-web T-Enhancement New feature or request
Milestone
Matrix Public Arc...

Comments

@MadLittleMods
Copy link
Contributor

Follow-up to #182 -> #196

Since we updated Hydrogen in #189, there are date headers throughout the timeline. But in cases like Gitter historical rooms where we imported a bunch of history, we have a lot of timestamp massaged messages with sprinkled in membership from a future date since we couldn't timestamp massage those.

We could prevent date headers from appearing for these rogue events that appear in the future.

Example where we are viewing messages from 2015-11-15 with a bunch of join events from 2023-01-30: .../roomid/PXiGeGziDhOzVYIsAc:gitter.im/date/2015/11/15
@MadLittleMods MadLittleMods added T-Enhancement New feature or request A-archive-room-view The view to look at a room day by day in the archive labels Apr 27, 2023
@MadLittleMods MadLittleMods mentioned this issue Apr 27, 2023
Open
@MadLittleMods MadLittleMods added the hydrogen Issues which involve https://github.com/vector-im/hydrogen-web label Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-archive-room-view The view to look at a room day by day in the archive hydrogen Issues which involve https://github.com/vector-im/hydrogen-web T-Enhancement New feature or request
Projects
None yet
Milestone
Matrix Public Archive v(next)
Development

No branches or pull requests
1 participant
@MadLittleMods