Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that /logout doesn't take a body #1644

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

reivilibre
Copy link
Contributor

@reivilibre reivilibre commented Sep 22, 2023

/logout says it does not take a request body1, so add it to the list of exceptions at the top.

I note that Complement does not send a request body for this endpoint, so that must mean Synapse and Dendrite allow that.

Preview: https://pr1644--matrix-spec-previews.netlify.app

Footnotes

  1. https://spec.matrix.org/v1.8/client-server-api/#post_matrixclientv3logout

@reivilibre reivilibre requested a review from a team as a code owner September 22, 2023 16:48
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm, this makes me sad.

I want to claim that this is misleading wording on behalf of the /logout endpoint definition, and a misfeature in complement/synapse/dendrite, rather than an indication that the body should actually allowed to be empty. Granting /logout an exception in this way very much puts it in a class of one.

On the other hand, it's clearly been this way since forever, and Element-Web relies upon it. So I guess I have to suck up the fact that there's an exception and make it something to fix for OIDC.

Anyway, /logout/all has the same problem I think.

changelogs/client_server/newsfragments/1644.clarification Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
@richvdh
Copy link
Member

richvdh commented Oct 3, 2023

(we should file a 'Wart' issue against the spec for this)

@richvdh
Copy link
Member

richvdh commented Feb 27, 2024

@reivilibre would you be able to update this?

@reivilibre
Copy link
Contributor Author

Issue created at #1845 but I don't have the ability to add a Wart label

@reivilibre reivilibre requested a review from richvdh June 5, 2024 15:11
content/client-server-api/_index.md Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
Co-authored-by: Richard van der Hoff <[email protected]>
@reivilibre reivilibre requested a review from richvdh June 7, 2024 11:04
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@richvdh richvdh merged commit 2f52802 into matrix-org:main Jun 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants