Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/logout does not take a request body, which is inconsistent #1845

Open
reivilibre opened this issue Jun 5, 2024 · 1 comment
Open

/logout does not take a request body, which is inconsistent #1845

reivilibre opened this issue Jun 5, 2024 · 1 comment
Labels
wart A point where the protocol is inconsistent or inelegant

Comments

@reivilibre
Copy link
Contributor

Other PUT and POST requests except for media upload take a JSON request body, even if that's just {}.

For some reason /logout is an exception to this, although it's not clear why or whether this is just an accident.

Area: https://spec.matrix.org/v1.8/client-server-api/#post_matrixclientv3logout
@reivilibre reivilibre mentioned this issue Jun 5, 2024
Merged
@richvdh richvdh added the wart A point where the protocol is inconsistent or inelegant label Jun 6, 2024
@richvdh
Copy link
Member

richvdh commented Jun 6, 2024

I think it's an accident. The original synapse impl just didn't check if there was a body, and then clients started relying on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wart A point where the protocol is inconsistent or inelegant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richvdh @reivilibre