Add event_property_is and event_property_contains props to PushCondit…

…ions (#1673) Signed-off-by: tusooa <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]>
matrix-org · Nov 16, 2023 · 25a9157 · 25a9157
1 parent 161a4a2
commit 25a9157
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/changelogs/client_server/newsfragments/1673.clarification b/changelogs/client_server/newsfragments/1673.clarification
@@ -0,0 +1 @@
+Add missing properties for `event_property_is` and `event_property_contains` push conditions to `PushConditions` object.
diff --git a/data/api/client-server/definitions/push_condition.yaml b/data/api/client-server/definitions/push_condition.yaml
@@ -23,8 +23,8 @@ properties:
   key:
     type: string
     description: |-
-      Required for `event_match` conditions. The dot-separated field of the
-      event to match.
+      Required for `event_match`, `event_property_is` and `event_property_contains`
+      conditions. The dot-separated field of the event to match.
 
       Required for `sender_notification_permission` conditions. The field in
       the power level event the user needs a minimum power level for. Fields
@@ -43,5 +43,11 @@ properties:
       optionally prefixed by one of, ==, <, >, >= or <=. A prefix of < matches
       rooms where the member count is strictly less than the given number and
       so forth. If no prefix is present, this parameter defaults to ==.
+  value:
+    type: ["string", "integer", "boolean", "null"]
+    description: |-
+      Required for `event_property_is` and `event_property_contains` conditions.
+      A non-compound [canonical JSON](/appendices#canonical-json) value to match
+      against.
 required:
   - kind