Skip to content

Commit

Permalink
Federation requests must be for local users. (#1672)
Browse files Browse the repository at this point in the history
This is already mentioned for /user/devices, but is not mentioned for /query/profile, /user/keys/claim, or /user/keys/query.

See GHSA-mp92-3jfm-3575 for an issue found with this in Synapse.
  • Loading branch information
clokep authored Nov 14, 2023
1 parent 7b72c42 commit 161a4a2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
1 change: 1 addition & 0 deletions changelogs/server_server/newsfragments/1672.clarification
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Clarify that federation requests for non-local users are invalid.
2 changes: 1 addition & 1 deletion data/api/server-server/query.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ paths:
parameters:
- in: query
name: user_id
description: The user ID to query.
description: The user ID to query. Must be a user local to the receiving homeserver.
required: true
example: "@someone:example.org"
schema:
Expand Down
6 changes: 4 additions & 2 deletions data/api/server-server/user_keys.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ paths:
type: object
description: |-
The keys to be claimed. A map from user ID, to a map from
device ID to algorithm name.
device ID to algorithm name. Requested users must be local
to the receiving homeserver.
additionalProperties:
type: object
additionalProperties:
Expand Down Expand Up @@ -121,7 +122,8 @@ paths:
description: |-
The keys to be downloaded. A map from user ID, to a list of
device IDs, or to an empty list to indicate all devices for the
corresponding user.
corresponding user. Requested users must be local to the
receiving homeserver.
additionalProperties:
type: array
items:
Expand Down

0 comments on commit 161a4a2

Please sign in to comment.