Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small sliding sync refactorings #2956

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Small sliding sync refactorings #2956

merged 3 commits into from
Dec 18, 2023

Commits on Dec 18, 2023

  1. sliding sync: optimize finding the room member state event 

    - We can look up the session meta only once, it's not useful to do it once per event as it's
loop-invariant.
- We can look at the events backwards and stop after the first room membership event we see
in that order.
    @bnjbvr
    bnjbvr committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    b5dd999 View commit details
    Browse the repository at this point in the history

  2. sliding sync: don't cause a spurious RoomInfo update 

    The room_info variable in this function contains the latest_event, and later it's set as the Room's room info (`inner.inner`) field.
Calling `set_latest_event` manually here will cause an update of the `RoomInfo` subscriber, while we're not done processing the full
room, and a room info update will happen anyways later (when the entire room is processed), so this one is spurious and will only
show a partial update of the fields.
    @bnjbvr
    bnjbvr committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    0c1fb08 View commit details
    Browse the repository at this point in the history

  3. style: remove spurious fully-qualified path

    @bnjbvr
    bnjbvr committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    d969da9 View commit details
    Browse the repository at this point in the history