Small sliding sync refactorings #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We can look up the session meta only once, it's not useful to do it once per event as it's loop-invariant. - We can look at the events backwards and stop after the first room membership event we see in that order.
The room_info variable in this function contains the latest_event, and later it's set as the Room's room info (`inner.inner`) field. Calling `set_latest_event` manually here will cause an update of the `RoomInfo` subscriber, while we're not done processing the full room, and a room info update will happen anyways later (when the entire room is processed), so this one is spurious and will only show a partial update of the fields.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2956 +/- ##
==========================================
- Coverage 83.50% 83.50% -0.01%
==========================================
Files 221 221
Lines 23009 23007 -2
==========================================
- Hits 19214 19211 -3
- Misses 3795 3796 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2953.