-
-
Notifications
You must be signed in to change notification settings - Fork 833
Fix bulk invite button getting a negative count #7122
Fix bulk invite button getting a negative count #7122
Conversation
Signed-off-by: Renan <[email protected]>
const onClickAccept = this.onAcceptAllInvitesClicked.bind(this); | ||
const onClickReject = this.onRejectAllInvitesClicked.bind(this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we avoid this?
|
||
constructor(props: IProps) { | ||
super(props); | ||
|
||
// Get number of rooms we're invited to | ||
const invitedRooms = this.getInvitedRooms(); | ||
this.notificationState = RoomNotificationStateStore.instance.getListState(DefaultTagID.Invite); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBCH, using the RoomNotificationStateStore
for this feels a little odd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, maybe RoomListStore
would be more logical here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, though I think it might be best to use the js-sdk directly (though you would need to filter out spaces), other people might view this differently
Signed-off-by: Renan <[email protected]>
return; | ||
} | ||
|
||
if (membership === "invite") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have a membership enum but it might be worth checking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find any membership enum :(
I can declare it, though it might be worth creating a PR only to handle this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, probably don'ŧ worry about it, it should be in the js-sdk, anyway
@@ -76,7 +76,7 @@ interface IState { | |||
ignoredUserIds: string[]; | |||
waitingUnignored: string[]; | |||
managingInvites: boolean; | |||
invitedRoomAmt: number; | |||
invitedRooms: Room[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're mainly adding and removing elements of this array, I think it could be better to use a Set
Signed-off-by: Renan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks!
* Make double-clicking the PiP take you to the call room ([\element-hq#7142](matrix-org/matrix-react-sdk#7142)). Fixes element-hq#18421 element-hq#15920 and element-hq#18421. Contributed by @SimonBrandner. * Add maximise widget functionality ([\element-hq#7098](matrix-org/matrix-react-sdk#7098)). Fixes element-hq#19619, element-hq#19621 element-hq#19760 and element-hq#19619. * Add rainfall effect ([\element-hq#7086](matrix-org/matrix-react-sdk#7086)). Contributed by @justjosias. * Add root folder to zip file created by export chat feature ([\element-hq#7097](matrix-org/matrix-react-sdk#7097)). Fixes element-hq#19653 and element-hq#19653. Contributed by @aaronraimist. * Improve VoIP UI/UX ([\element-hq#7048](matrix-org/matrix-react-sdk#7048)). Fixes element-hq#19513 and element-hq#19513. Contributed by @SimonBrandner. * Unified room context menus ([\element-hq#7072](matrix-org/matrix-react-sdk#7072)). Fixes element-hq#19527 and element-hq#19527. * In forgot password screen, show validation errors inline in the form, instead of in modals ([\element-hq#7113](matrix-org/matrix-react-sdk#7113)). Contributed by @psrpinto. * Implement more meta-spaces ([\element-hq#7077](matrix-org/matrix-react-sdk#7077)). Fixes element-hq#18634 element-hq#17295 and element-hq#18634. * Expose power level control for m.space.child ([\#7120](matrix-org/matrix-react-sdk#7120)). * Forget member-list query when switching out of a room ([\element-hq#7093](matrix-org/matrix-react-sdk#7093)). Fixes element-hq#19432 and element-hq#19432. Contributed by @SimonBrandner. * Do pre-submit availability check on username during registration ([\#6978](matrix-org/matrix-react-sdk#6978)). Fixes element-hq#9545 and element-hq#9545. * Adjust recovery key button sizes depending on text width ([\element-hq#7134](matrix-org/matrix-react-sdk#7134)). Fixes element-hq#19511 and element-hq#19511. Contributed by @weeman1337. * Fix bulk invite button getting a negative count ([\element-hq#7122](matrix-org/matrix-react-sdk#7122)). Fixes element-hq#19466 and element-hq#19466. Contributed by @renancleyson-dev. * Fix maximised / pinned widget state being loaded correctly ([\element-hq#7146](matrix-org/matrix-react-sdk#7146)). Fixes element-hq#19768 and element-hq#19768. * Don't reload the page when user hits enter when entering ban reason ([\element-hq#7145](matrix-org/matrix-react-sdk#7145)). Fixes element-hq#19763 and element-hq#19763. * Fix timeline text when sharing room layout ([\element-hq#7140](matrix-org/matrix-react-sdk#7140)). Fixes element-hq#19622 and element-hq#19622. * Fix look of emoji verification ([\element-hq#7133](matrix-org/matrix-react-sdk#7133)). Fixes element-hq#19740 and element-hq#19740. Contributed by @SimonBrandner. * Fixes element not remembering widget hidden state per room ([\#7136](matrix-org/matrix-react-sdk#7136)). Fixes element-hq#16672, matrix-org/element-web-rageshakes#4407, element-hq#15718 element-hq#15768 and element-hq#16672. * Don't keep spinning if joining space child failed ([\element-hq#7129](matrix-org/matrix-react-sdk#7129)). Fixes matrix-org/element-web-rageshakes#6813 and matrix-org/element-web-rageshakes#6813. * Guard around SpaceStore onAccountData handler prevEvent ([\element-hq#7123](matrix-org/matrix-react-sdk#7123)). Fixes element-hq#19705 and element-hq#19705. * Fix missing spaces in threads copy ([\element-hq#7119](matrix-org/matrix-react-sdk#7119)). Fixes element-hq#19702 and element-hq#19702. * Fix hover tile border ([\element-hq#7117](matrix-org/matrix-react-sdk#7117)). Fixes element-hq#19698 and element-hq#19698. Contributed by @SimonBrandner. * Fix quote button ([\element-hq#7096](matrix-org/matrix-react-sdk#7096)). Fixes element-hq#19659 and element-hq#19659. Contributed by @SimonBrandner. * Fix space panel layout edge cases ([\#7101](matrix-org/matrix-react-sdk#7101)). Fixes element-hq#19668 and element-hq#19668. * Update powerlevel/role when the user changes in the user info panel ([\element-hq#7099](matrix-org/matrix-react-sdk#7099)). Fixes element-hq#19666 and element-hq#19666. Contributed by @SimonBrandner. * Fix avatar disappearing when setting a room topic ([\element-hq#7092](matrix-org/matrix-react-sdk#7092)). Fixes element-hq#19226 and element-hq#19226. Contributed by @SimonBrandner. * Fix possible infinite loop on widget start ([\#7071](matrix-org/matrix-react-sdk#7071)). Fixes element-hq#15494 and element-hq#15494. * Use device IDs for nameless devices in device list ([\element-hq#7081](matrix-org/matrix-react-sdk#7081)). Fixes element-hq#19608 and element-hq#19608. * Don't re-sort rooms on no-op RoomUpdateCause.PossibleTagChange ([\element-hq#7053](matrix-org/matrix-react-sdk#7053)). Contributed by @bradtgmurray.
* Make double-clicking the PiP take you to the call room ([\#7142](matrix-org/matrix-react-sdk#7142)). Fixes element-hq/element-web#18421 element-hq/element-web#15920 and element-hq/element-web#18421. Contributed by @SimonBrandner. * Add maximise widget functionality ([\#7098](matrix-org/matrix-react-sdk#7098)). Fixes element-hq/element-web#19619, element-hq/element-web#19621 element-hq/element-web#19760 and element-hq/element-web#19619. * Add rainfall effect ([\#7086](matrix-org/matrix-react-sdk#7086)). Contributed by @justjosias. * Add root folder to zip file created by export chat feature ([\#7097](matrix-org/matrix-react-sdk#7097)). Fixes element-hq/element-web#19653 and element-hq/element-web#19653. Contributed by @aaronraimist. * Improve VoIP UI/UX ([\#7048](matrix-org/matrix-react-sdk#7048)). Fixes element-hq/element-web#19513 and element-hq/element-web#19513. Contributed by @SimonBrandner. * Unified room context menus ([\#7072](matrix-org/matrix-react-sdk#7072)). Fixes element-hq/element-web#19527 and element-hq/element-web#19527. * In forgot password screen, show validation errors inline in the form, instead of in modals ([\#7113](matrix-org/matrix-react-sdk#7113)). Contributed by @psrpinto. * Implement more meta-spaces ([\#7077](matrix-org/matrix-react-sdk#7077)). Fixes element-hq/element-web#18634 element-hq/element-web#17295 and element-hq/element-web#18634. * Expose power level control for m.space.child ([\#7120](matrix-org/matrix-react-sdk#7120)). * Forget member-list query when switching out of a room ([\#7093](matrix-org/matrix-react-sdk#7093)). Fixes element-hq/element-web#19432 and element-hq/element-web#19432. Contributed by @SimonBrandner. * Do pre-submit availability check on username during registration ([\#6978](matrix-org/matrix-react-sdk#6978)). Fixes element-hq/element-web#9545 and element-hq/element-web#9545. * Adjust recovery key button sizes depending on text width ([\#7134](matrix-org/matrix-react-sdk#7134)). Fixes element-hq/element-web#19511 and element-hq/element-web#19511. Contributed by @weeman1337. * Fix bulk invite button getting a negative count ([\#7122](matrix-org/matrix-react-sdk#7122)). Fixes element-hq/element-web#19466 and element-hq/element-web#19466. Contributed by @renancleyson-dev. * Fix maximised / pinned widget state being loaded correctly ([\#7146](matrix-org/matrix-react-sdk#7146)). Fixes element-hq/element-web#19768 and element-hq/element-web#19768. * Don't reload the page when user hits enter when entering ban reason ([\#7145](matrix-org/matrix-react-sdk#7145)). Fixes element-hq/element-web#19763 and element-hq/element-web#19763. * Fix timeline text when sharing room layout ([\#7140](matrix-org/matrix-react-sdk#7140)). Fixes element-hq/element-web#19622 and element-hq/element-web#19622. * Fix look of emoji verification ([\#7133](matrix-org/matrix-react-sdk#7133)). Fixes element-hq/element-web#19740 and element-hq/element-web#19740. Contributed by @SimonBrandner. * Fixes element not remembering widget hidden state per room ([\#7136](matrix-org/matrix-react-sdk#7136)). Fixes element-hq/element-web#16672, matrix-org/element-web-rageshakes#4407, element-hq/element-web#15718 element-hq/element-web#15768 and element-hq/element-web#16672. * Don't keep spinning if joining space child failed ([\#7129](matrix-org/matrix-react-sdk#7129)). Fixes matrix-org/element-web-rageshakes#6813 and matrix-org/element-web-rageshakes#6813. * Guard around SpaceStore onAccountData handler prevEvent ([\#7123](matrix-org/matrix-react-sdk#7123)). Fixes element-hq/element-web#19705 and element-hq/element-web#19705. * Fix missing spaces in threads copy ([\#7119](matrix-org/matrix-react-sdk#7119)). Fixes element-hq/element-web#19702 and element-hq/element-web#19702. * Fix hover tile border ([\#7117](matrix-org/matrix-react-sdk#7117)). Fixes element-hq/element-web#19698 and element-hq/element-web#19698. Contributed by @SimonBrandner. * Fix quote button ([\#7096](matrix-org/matrix-react-sdk#7096)). Fixes element-hq/element-web#19659 and element-hq/element-web#19659. Contributed by @SimonBrandner. * Fix space panel layout edge cases ([\#7101](matrix-org/matrix-react-sdk#7101)). Fixes element-hq/element-web#19668 and element-hq/element-web#19668. * Update powerlevel/role when the user changes in the user info panel ([\#7099](matrix-org/matrix-react-sdk#7099)). Fixes element-hq/element-web#19666 and element-hq/element-web#19666. Contributed by @SimonBrandner. * Fix avatar disappearing when setting a room topic ([\#7092](matrix-org/matrix-react-sdk#7092)). Fixes element-hq/element-web#19226 and element-hq/element-web#19226. Contributed by @SimonBrandner. * Fix possible infinite loop on widget start ([\#7071](matrix-org/matrix-react-sdk#7071)). Fixes element-hq/element-web#15494 and element-hq/element-web#15494. * Use device IDs for nameless devices in device list ([\#7081](matrix-org/matrix-react-sdk#7081)). Fixes element-hq/element-web#19608 and element-hq/element-web#19608. * Don't re-sort rooms on no-op RoomUpdateCause.PossibleTagChange ([\#7053](matrix-org/matrix-react-sdk#7053)). Contributed by @bradtgmurray.
* Make double-clicking the PiP take you to the call room ([\element-hq#7142](matrix-org/matrix-react-sdk#7142)). Fixes element-hq#18421 element-hq#15920 and element-hq#18421. Contributed by @SimonBrandner. * Add maximise widget functionality ([\element-hq#7098](matrix-org/matrix-react-sdk#7098)). Fixes element-hq#19619, element-hq#19621 element-hq#19760 and element-hq#19619. * Add rainfall effect ([\element-hq#7086](matrix-org/matrix-react-sdk#7086)). Contributed by @justjosias. * Add root folder to zip file created by export chat feature ([\element-hq#7097](matrix-org/matrix-react-sdk#7097)). Fixes element-hq#19653 and element-hq#19653. Contributed by @aaronraimist. * Improve VoIP UI/UX ([\element-hq#7048](matrix-org/matrix-react-sdk#7048)). Fixes element-hq#19513 and element-hq#19513. Contributed by @SimonBrandner. * Unified room context menus ([\element-hq#7072](matrix-org/matrix-react-sdk#7072)). Fixes element-hq#19527 and element-hq#19527. * In forgot password screen, show validation errors inline in the form, instead of in modals ([\element-hq#7113](matrix-org/matrix-react-sdk#7113)). Contributed by @psrpinto. * Implement more meta-spaces ([\element-hq#7077](matrix-org/matrix-react-sdk#7077)). Fixes element-hq#18634 element-hq#17295 and element-hq#18634. * Expose power level control for m.space.child ([\#7120](matrix-org/matrix-react-sdk#7120)). * Forget member-list query when switching out of a room ([\element-hq#7093](matrix-org/matrix-react-sdk#7093)). Fixes element-hq#19432 and element-hq#19432. Contributed by @SimonBrandner. * Do pre-submit availability check on username during registration ([\#6978](matrix-org/matrix-react-sdk#6978)). Fixes element-hq#9545 and element-hq#9545. * Adjust recovery key button sizes depending on text width ([\element-hq#7134](matrix-org/matrix-react-sdk#7134)). Fixes element-hq#19511 and element-hq#19511. Contributed by @weeman1337. * Fix bulk invite button getting a negative count ([\element-hq#7122](matrix-org/matrix-react-sdk#7122)). Fixes element-hq#19466 and element-hq#19466. Contributed by @renancleyson-dev. * Fix maximised / pinned widget state being loaded correctly ([\element-hq#7146](matrix-org/matrix-react-sdk#7146)). Fixes element-hq#19768 and element-hq#19768. * Don't reload the page when user hits enter when entering ban reason ([\element-hq#7145](matrix-org/matrix-react-sdk#7145)). Fixes element-hq#19763 and element-hq#19763. * Fix timeline text when sharing room layout ([\element-hq#7140](matrix-org/matrix-react-sdk#7140)). Fixes element-hq#19622 and element-hq#19622. * Fix look of emoji verification ([\element-hq#7133](matrix-org/matrix-react-sdk#7133)). Fixes element-hq#19740 and element-hq#19740. Contributed by @SimonBrandner. * Fixes element not remembering widget hidden state per room ([\#7136](matrix-org/matrix-react-sdk#7136)). Fixes element-hq#16672, matrix-org/element-web-rageshakes#4407, element-hq#15718 element-hq#15768 and element-hq#16672. * Don't keep spinning if joining space child failed ([\element-hq#7129](matrix-org/matrix-react-sdk#7129)). Fixes matrix-org/element-web-rageshakes#6813 and matrix-org/element-web-rageshakes#6813. * Guard around SpaceStore onAccountData handler prevEvent ([\element-hq#7123](matrix-org/matrix-react-sdk#7123)). Fixes element-hq#19705 and element-hq#19705. * Fix missing spaces in threads copy ([\element-hq#7119](matrix-org/matrix-react-sdk#7119)). Fixes element-hq#19702 and element-hq#19702. * Fix hover tile border ([\element-hq#7117](matrix-org/matrix-react-sdk#7117)). Fixes element-hq#19698 and element-hq#19698. Contributed by @SimonBrandner. * Fix quote button ([\element-hq#7096](matrix-org/matrix-react-sdk#7096)). Fixes element-hq#19659 and element-hq#19659. Contributed by @SimonBrandner. * Fix space panel layout edge cases ([\#7101](matrix-org/matrix-react-sdk#7101)). Fixes element-hq#19668 and element-hq#19668. * Update powerlevel/role when the user changes in the user info panel ([\element-hq#7099](matrix-org/matrix-react-sdk#7099)). Fixes element-hq#19666 and element-hq#19666. Contributed by @SimonBrandner. * Fix avatar disappearing when setting a room topic ([\element-hq#7092](matrix-org/matrix-react-sdk#7092)). Fixes element-hq#19226 and element-hq#19226. Contributed by @SimonBrandner. * Fix possible infinite loop on widget start ([\#7071](matrix-org/matrix-react-sdk#7071)). Fixes element-hq#15494 and element-hq#15494. * Use device IDs for nameless devices in device list ([\element-hq#7081](matrix-org/matrix-react-sdk#7081)). Fixes element-hq#19608 and element-hq#19608. * Don't re-sort rooms on no-op RoomUpdateCause.PossibleTagChange ([\element-hq#7053](matrix-org/matrix-react-sdk#7053)). Contributed by @bradtgmurray.
Changes in [1.9.7](https://github.com/vector-im/element-web/releases/tag/v1.9.7) (2021-12-13) ============================================================================================= * Security release with updated version of Olm to fix https://matrix.org/blog/2021/12/03/pre-disclosure-upcoming-security-release-of-libolm-and-matrix-js-sdk * Fix a crash on logout Changes in [1.9.6](https://github.com/vector-im/element-web/releases/tag/v1.9.6) (2021-12-06) ============================================================================================= ## ✨ Features * Add unread indicator to the timelineCard header icon ([\#7156](matrix-org/matrix-react-sdk#7156)). Fixes #19635. * Only show core navigation elements (call/chat/notification/info) when a widget is maximised ([\#7114](matrix-org/matrix-react-sdk#7114)). Fixes #19632. * Improve ThreadPanel ctx menu accessibility ([\#7217](matrix-org/matrix-react-sdk#7217)). Fixes #19885. * Allow filtering room list during treeview navigation ([\#7219](matrix-org/matrix-react-sdk#7219)). Fixes #14702. * Add right panel chat timeline ([\#7112](matrix-org/matrix-react-sdk#7112)). Fixes #19633. * Hide server options hint when disable_custom_urls is true ([\#7215](matrix-org/matrix-react-sdk#7215)). Fixes #19919. * Improve right panel resize handle usability ([\#7204](matrix-org/matrix-react-sdk#7204)). Fixes #15145. Contributed by @weeman1337. * Spaces quick settings ([\#7196](matrix-org/matrix-react-sdk#7196)). * Maximised widgets always force a call to be shown in PIP mode ([\#7163](matrix-org/matrix-react-sdk#7163)). Fixes #19637. * Group Labs flags ([\#7190](matrix-org/matrix-react-sdk#7190)). * Show room context details in forward dialog ([\#7162](matrix-org/matrix-react-sdk#7162)). Fixes #19793. * Remove chevrons from RoomSummaryCard_Button ([\#7137](matrix-org/matrix-react-sdk#7137)). Fixes #19644. * Disable op/deop commands where user has no permissions ([\#7161](matrix-org/matrix-react-sdk#7161)). Fixes #15390. * Add option to change the size of images/videos in the timeline ([\#7017](matrix-org/matrix-react-sdk#7017)). Fixes element-hq/element-meta#49 #1520 and #19498. ## 🐛 Bug Fixes * Fix left panel glow in Safari ([\#7236](matrix-org/matrix-react-sdk#7236)). Fixes #19863. * Fix newline on edit messages with quotes ([\#7227](matrix-org/matrix-react-sdk#7227)). Fixes #12535. Contributed by @renancleyson-dev. * Guard against null refs in findSiblingElement ([\#7228](matrix-org/matrix-react-sdk#7228)). * Tweak bottom of space panel buttons in expanded state ([\#7213](matrix-org/matrix-react-sdk#7213)). Fixes #19921. * Fix multiline paragraph rendering as single line ([\#7210](matrix-org/matrix-react-sdk#7210)). Fixes #8786. Contributed by @renancleyson-dev. * Improve room list message previews ([\#7224](matrix-org/matrix-react-sdk#7224)). Fixes #17101 and #16169. * Fix EmojiPicker lazy loaded rendering bug ([\#7225](matrix-org/matrix-react-sdk#7225)). Fixes #15341. * Prevent default avatar in UserInfo having pointer cursor ([\#7218](matrix-org/matrix-react-sdk#7218)). Fixes #13872. * Prevent duplicate avatars in Event List Summaries ([\#7222](matrix-org/matrix-react-sdk#7222)). Fixes #17706. * Respect the home page as a context for the Home space ([\#7216](matrix-org/matrix-react-sdk#7216)). Fixes #19554. * Fix RoomUpgradeWarningBar exploding ([\#7214](matrix-org/matrix-react-sdk#7214)). Fixes #19920. * Polish threads misalignments and UI diversion ([\#7209](matrix-org/matrix-react-sdk#7209)). Fixes #19772, #19710 #19629 and #19711. * Fix Manage Restricted Join Rule Dialog for Spaces ([\#7208](matrix-org/matrix-react-sdk#7208)). Fixes #19610. * Fix wrongly showing unpin in pinned messages tile with no perms ([\#7197](matrix-org/matrix-react-sdk#7197)). Fixes #19886. * Make image size constrained by height when using the ImageSize.Large option ([\#7171](matrix-org/matrix-react-sdk#7171)). Fixes #19788. * Prevent programmatic scrolling within truncated room sublists ([\#7191](matrix-org/matrix-react-sdk#7191)). * Remove leading slash from /addwidget Jitsi confs ([\#7175](matrix-org/matrix-react-sdk#7175)). Fixes #19839. Contributed by @AndrewFerr. * Fix automatic composer focus, regressed by threads work ([\#7167](matrix-org/matrix-react-sdk#7167)). Fixes #19479. * Show space members when not invited even if summary didn't fail ([\#7153](matrix-org/matrix-react-sdk#7153)). Fixes #19781. * Prevent custom power levels from breaking roles & permissions tab ([\#7160](matrix-org/matrix-react-sdk#7160)). Fixes #19812. * Room Context Menu should respond to tag changes ([\#7154](matrix-org/matrix-react-sdk#7154)). Fixes #19776. * Fix an edge case when trying to join an upgraded room ([\#7159](matrix-org/matrix-react-sdk#7159)). Changes in [1.9.6-rc.2](https://github.com/vector-im/element-web/releases/tag/v1.9.6-rc.2) (2021-12-01) ======================================================================================================= * Fixed release from correct branch Changes in [1.9.6-rc.1](https://github.com/vector-im/element-web/releases/tag/v1.9.6-rc.1) (2021-11-30) ======================================================================================================= ## ✨ Features * Tweaks to informational architecture 1.1 ([\#7052](matrix-org/matrix-react-sdk#7052)). Fixes #19526, #19379, #17792, #16450, #19881, #19892, #19300, #19324, #17307, #17468, #19932 #19956 and #19526. * Add unread indicator to the timelineCard header icon ([\#7156](matrix-org/matrix-react-sdk#7156)). Fixes #19635 and #19635. * Only show core navigation elements (call/chat/notification/info) when a widget is maximised ([\#7114](matrix-org/matrix-react-sdk#7114)). Fixes #19632 and #19632. * Improve ThreadPanel ctx menu accessibility ([\#7217](matrix-org/matrix-react-sdk#7217)). Fixes #19885 and #19885. * Allow filtering room list during treeview navigation ([\#7219](matrix-org/matrix-react-sdk#7219)). Fixes #14702 and #14702. * Add right panel chat timeline ([\#7112](matrix-org/matrix-react-sdk#7112)). Fixes #19633 and #19633. * Hide server options hint when disable_custom_urls is true ([\#7215](matrix-org/matrix-react-sdk#7215)). Fixes #19919 and #19919. * Improve right panel resize handle usability ([\#7204](matrix-org/matrix-react-sdk#7204)). Fixes #15145 and #15145. Contributed by @weeman1337. * Spaces quick settings ([\#7196](matrix-org/matrix-react-sdk#7196)). * Maximised widgets always force a call to be shown in PIP mode ([\#7163](matrix-org/matrix-react-sdk#7163)). Fixes #19637 and #19637. * Group Labs flags ([\#7190](matrix-org/matrix-react-sdk#7190)). * Show room context details in forward dialog ([\#7162](matrix-org/matrix-react-sdk#7162)). Fixes #19793 and #19793. * Remove chevrons from RoomSummaryCard_Button ([\#7137](matrix-org/matrix-react-sdk#7137)). Fixes #19644 and #19644. * Disable op/deop commands where user has no permissions ([\#7161](matrix-org/matrix-react-sdk#7161)). Fixes #15390 and #15390. * Add option to change the size of images/videos in the timeline ([\#7017](matrix-org/matrix-react-sdk#7017)). Fixes element-hq/element-meta#49, #1520 #19498 and element-hq/element-meta#49. ## 🐛 Bug Fixes * Fix links being parsed as markdown links improperly ([\#7200](matrix-org/matrix-react-sdk#7200)). * Fix left panel glow in Safari ([\#7236](matrix-org/matrix-react-sdk#7236)). Fixes #19863 and #19863. * Fix newline on edit messages with quotes ([\#7227](matrix-org/matrix-react-sdk#7227)). Fixes #12535 and #12535. Contributed by @renancleyson-dev. * Guard against null refs in findSiblingElement ([\#7228](matrix-org/matrix-react-sdk#7228)). * Tweak bottom of space panel buttons in expanded state ([\#7213](matrix-org/matrix-react-sdk#7213)). Fixes #19921 and #19921. * Fix multiline paragraph rendering as single line ([\#7210](matrix-org/matrix-react-sdk#7210)). Fixes #8786 and #8786. Contributed by @renancleyson-dev. * Improve room list message previews ([\#7224](matrix-org/matrix-react-sdk#7224)). Fixes #17101 #16169 and #17101. * Fix EmojiPicker lazy loaded rendering bug ([\#7225](matrix-org/matrix-react-sdk#7225)). Fixes #15341 and #15341. * Prevent default avatar in UserInfo having pointer cursor ([\#7218](matrix-org/matrix-react-sdk#7218)). Fixes #13872 and #13872. * Prevent duplicate avatars in Event List Summaries ([\#7222](matrix-org/matrix-react-sdk#7222)). Fixes #17706 and #17706. * Respect the home page as a context for the Home space ([\#7216](matrix-org/matrix-react-sdk#7216)). Fixes #19554 and #19554. * Fix RoomUpgradeWarningBar exploding ([\#7214](matrix-org/matrix-react-sdk#7214)). Fixes #19920 and #19920. * Polish threads misalignments and UI diversion ([\#7209](matrix-org/matrix-react-sdk#7209)). Fixes #19772, #19710, #19629 #19711 and #19772. * Fix Manage Restricted Join Rule Dialog for Spaces ([\#7208](matrix-org/matrix-react-sdk#7208)). Fixes #19610 and #19610. * Fix wrongly showing unpin in pinned messages tile with no perms ([\#7197](matrix-org/matrix-react-sdk#7197)). Fixes #19886 and #19886. * Make image size constrained by height when using the ImageSize.Large option ([\#7171](matrix-org/matrix-react-sdk#7171)). Fixes #19788 and #19788. * Prevent programmatic scrolling within truncated room sublists ([\#7191](matrix-org/matrix-react-sdk#7191)). * Remove leading slash from /addwidget Jitsi confs ([\#7175](matrix-org/matrix-react-sdk#7175)). Fixes #19839 and #19839. Contributed by @AndrewFerr. * Fix automatic composer focus, regressed by threads work ([\#7167](matrix-org/matrix-react-sdk#7167)). Fixes #19479 and #19479. * Show space members when not invited even if summary didn't fail ([\#7153](matrix-org/matrix-react-sdk#7153)). Fixes #19781 and #19781. * Prevent custom power levels from breaking roles & permissions tab ([\#7160](matrix-org/matrix-react-sdk#7160)). Fixes #19812 and #19812. * Room Context Menu should respond to tag changes ([\#7154](matrix-org/matrix-react-sdk#7154)). Fixes #19776. * Fix an edge case when trying to join an upgraded room ([\#7159](matrix-org/matrix-react-sdk#7159)). Changes in [1.9.5](https://github.com/vector-im/element-web/releases/tag/v1.9.5) (2021-11-22) ============================================================================================= ## ✨ Features * Make double-clicking the PiP take you to the call room ([\#7142](matrix-org/matrix-react-sdk#7142)). Fixes #18421 #15920 and #18421. Contributed by @SimonBrandner. * Add maximise widget functionality ([\#7098](matrix-org/matrix-react-sdk#7098)). Fixes #19619, #19621 #19760 and #19619. * Add rainfall effect ([\#7086](matrix-org/matrix-react-sdk#7086)). Contributed by @justjosias. * Add root folder to zip file created by export chat feature ([\#7097](matrix-org/matrix-react-sdk#7097)). Fixes #19653 and #19653. Contributed by @aaronraimist. * Improve VoIP UI/UX ([\#7048](matrix-org/matrix-react-sdk#7048)). Fixes #19513 and #19513. Contributed by @SimonBrandner. * Unified room context menus ([\#7072](matrix-org/matrix-react-sdk#7072)). Fixes #19527 and #19527. * In forgot password screen, show validation errors inline in the form, instead of in modals ([\#7113](matrix-org/matrix-react-sdk#7113)). Contributed by @psrpinto. * Implement more meta-spaces ([\#7077](matrix-org/matrix-react-sdk#7077)). Fixes #18634 #17295 and #18634. * Expose power level control for m.space.child ([\#7120](matrix-org/matrix-react-sdk#7120)). * Forget member-list query when switching out of a room ([\#7093](matrix-org/matrix-react-sdk#7093)). Fixes #19432 and #19432. Contributed by @SimonBrandner. * Do pre-submit availability check on username during registration ([\#6978](matrix-org/matrix-react-sdk#6978)). Fixes #9545 and #9545. ## 🐛 Bug Fixes * Adjust recovery key button sizes depending on text width ([\#7134](matrix-org/matrix-react-sdk#7134)). Fixes #19511 and #19511. Contributed by @weeman1337. * Fix bulk invite button getting a negative count ([\#7122](matrix-org/matrix-react-sdk#7122)). Fixes #19466 and #19466. Contributed by @renancleyson-dev. * Fix maximised / pinned widget state being loaded correctly ([\#7146](matrix-org/matrix-react-sdk#7146)). Fixes #19768 and #19768. * Don't reload the page when user hits enter when entering ban reason ([\#7145](matrix-org/matrix-react-sdk#7145)). Fixes #19763 and #19763. * Fix timeline text when sharing room layout ([\#7140](matrix-org/matrix-react-sdk#7140)). Fixes #19622 and #19622. * Fix look of emoji verification ([\#7133](matrix-org/matrix-react-sdk#7133)). Fixes #19740 and #19740. Contributed by @SimonBrandner. * Fixes element not remembering widget hidden state per room ([\#7136](matrix-org/matrix-react-sdk#7136)). Fixes #16672, matrix-org/element-web-rageshakes#4407, #15718 #15768 and #16672. * Don't keep spinning if joining space child failed ([\#7129](matrix-org/matrix-react-sdk#7129)). Fixes matrix-org/element-web-rageshakes#6813 and matrix-org/element-web-rageshakes#6813. * Guard around SpaceStore onAccountData handler prevEvent ([\#7123](matrix-org/matrix-react-sdk#7123)). Fixes #19705 and #19705. * Fix missing spaces in threads copy ([\#7119](matrix-org/matrix-react-sdk#7119)). Fixes #19702 and #19702. * Fix hover tile border ([\#7117](matrix-org/matrix-react-sdk#7117)). Fixes #19698 and #19698. Contributed by @SimonBrandner. * Fix quote button ([\#7096](matrix-org/matrix-react-sdk#7096)). Fixes #19659 and #19659. Contributed by @SimonBrandner. * Fix space panel layout edge cases ([\#7101](matrix-org/matrix-react-sdk#7101)). Fixes #19668 and #19668. * Update powerlevel/role when the user changes in the user info panel ([\#7099](matrix-org/matrix-react-sdk#7099)). Fixes #19666 and #19666. Contributed by @SimonBrandner. * Fix avatar disappearing when setting a room topic ([\#7092](matrix-org/matrix-react-sdk#7092)). Fixes #19226 and #19226. Contributed by @SimonBrandner. * Fix possible infinite loop on widget start ([\#7071](matrix-org/matrix-react-sdk#7071)). Fixes #15494 and #15494. * Use device IDs for nameless devices in device list ([\#7081](matrix-org/matrix-react-sdk#7081)). Fixes #19608 and #19608. * Don't re-sort rooms on no-op RoomUpdateCause.PossibleTagChange ([\#7053](matrix-org/matrix-react-sdk#7053)). Contributed by @bradtgmurray. Changes in [1.9.5-rc.1](https://github.com/vector-im/element-web/releases/tag/v1.9.5-rc.1) (2021-11-17) ======================================================================================================= ## ✨ Features * Make double-clicking the PiP take you to the call room ([\#7142](matrix-org/matrix-react-sdk#7142)). Fixes #18421 #15920 and #18421. Contributed by @SimonBrandner. * Add maximise widget functionality ([\#7098](matrix-org/matrix-react-sdk#7098)). Fixes #19619, #19621 #19760 and #19619. * Add rainfall effect ([\#7086](matrix-org/matrix-react-sdk#7086)). Contributed by @justjosias. * Add root folder to zip file created by export chat feature ([\#7097](matrix-org/matrix-react-sdk#7097)). Fixes #19653 and #19653. Contributed by @aaronraimist. * Improve VoIP UI/UX ([\#7048](matrix-org/matrix-react-sdk#7048)). Fixes #19513 and #19513. Contributed by @SimonBrandner. * Unified room context menus ([\#7072](matrix-org/matrix-react-sdk#7072)). Fixes #19527 and #19527. * In forgot password screen, show validation errors inline in the form, instead of in modals ([\#7113](matrix-org/matrix-react-sdk#7113)). Contributed by @psrpinto. * Implement more meta-spaces ([\#7077](matrix-org/matrix-react-sdk#7077)). Fixes #18634 #17295 and #18634. * Expose power level control for m.space.child ([\#7120](matrix-org/matrix-react-sdk#7120)). * Forget member-list query when switching out of a room ([\#7093](matrix-org/matrix-react-sdk#7093)). Fixes #19432 and #19432. Contributed by @SimonBrandner. * Do pre-submit availability check on username during registration ([\#6978](matrix-org/matrix-react-sdk#6978)). Fixes #9545 and #9545. ## 🐛 Bug Fixes * Adjust recovery key button sizes depending on text width ([\#7134](matrix-org/matrix-react-sdk#7134)). Fixes #19511 and #19511. Contributed by @weeman1337. * Fix bulk invite button getting a negative count ([\#7122](matrix-org/matrix-react-sdk#7122)). Fixes #19466 and #19466. Contributed by @renancleyson-dev. * Fix maximised / pinned widget state being loaded correctly ([\#7146](matrix-org/matrix-react-sdk#7146)). Fixes #19768 and #19768. * Don't reload the page when user hits enter when entering ban reason ([\#7145](matrix-org/matrix-react-sdk#7145)). Fixes #19763 and #19763. * Fix timeline text when sharing room layout ([\#7140](matrix-org/matrix-react-sdk#7140)). Fixes #19622 and #19622. * Fix look of emoji verification ([\#7133](matrix-org/matrix-react-sdk#7133)). Fixes #19740 and #19740. Contributed by @SimonBrandner. * Fixes element not remembering widget hidden state per room ([\#7136](matrix-org/matrix-react-sdk#7136)). Fixes #16672, matrix-org/element-web-rageshakes#4407, #15718 #15768 and #16672. * Don't keep spinning if joining space child failed ([\#7129](matrix-org/matrix-react-sdk#7129)). Fixes matrix-org/element-web-rageshakes#6813 and matrix-org/element-web-rageshakes#6813. * Guard around SpaceStore onAccountData handler prevEvent ([\#7123](matrix-org/matrix-react-sdk#7123)). Fixes #19705 and #19705. * Fix missing spaces in threads copy ([\#7119](matrix-org/matrix-react-sdk#7119)). Fixes #19702 and #19702. * Fix hover tile border ([\#7117](matrix-org/matrix-react-sdk#7117)). Fixes #19698 and #19698. Contributed by @SimonBrandner. * Fix quote button ([\#7096](matrix-org/matrix-react-sdk#7096)). Fixes #19659 and #19659. Contributed by @SimonBrandner. * Fix space panel layout edge cases ([\#7101](matrix-org/matrix-react-sdk#7101)). Fixes #19668 and #19668. * Update powerlevel/role when the user changes in the user info panel ([\#7099](matrix-org/matrix-react-sdk#7099)). Fixes #19666 and #19666. Contributed by @SimonBrandner. * Fix avatar disappearing when setting a room topic ([\#7092](matrix-org/matrix-react-sdk#7092)). Fixes #19226 and #19226. Contributed by @SimonBrandner. * Fix possible infinite loop on widget start ([\#7071](matrix-org/matrix-react-sdk#7071)). Fixes #15494 and #15494. * Use device IDs for nameless devices in device list ([\#7081](matrix-org/matrix-react-sdk#7081)). Fixes #19608 and #19608. * Don't re-sort rooms on no-op RoomUpdateCause.PossibleTagChange ([\#7053](matrix-org/matrix-react-sdk#7053)). Contributed by @bradtgmurray. Changes in [1.9.4](https://github.com/vector-im/element-web/releases/tag/v1.9.4) (2021-11-08) ============================================================================================= ## ✨ Features * Improve the look of tooltips ([\#7049](matrix-org/matrix-react-sdk#7049)). Contributed by @SimonBrandner. * Improve the look of the spinner ([\#6083](matrix-org/matrix-react-sdk#6083)). Contributed by @SimonBrandner. * Polls: Creation form & start event ([\#7001](matrix-org/matrix-react-sdk#7001)). * Show a gray shield when encrypted by deleted session ([\#6119](matrix-org/matrix-react-sdk#6119)). Contributed by @SimonBrandner. * <notes> ([\#7057](matrix-org/matrix-react-sdk#7057)). Contributed by @ndarilek. * Make message separator more accessible. ([\#7056](matrix-org/matrix-react-sdk#7056)). Contributed by @ndarilek. * <notes> ([\#7035](matrix-org/matrix-react-sdk#7035)). Contributed by @ndarilek. * Implement RequiresClient capability for widgets ([\#7005](matrix-org/matrix-react-sdk#7005)). Fixes #15744 and #15744. * Respect the system high contrast setting when using system theme ([\#7043](matrix-org/matrix-react-sdk#7043)). * Remove redundant duplicate mimetype field which doesn't conform to spec ([\#7045](matrix-org/matrix-react-sdk#7045)). Fixes #17145 and #17145. * Make join button on space hierarchy action in the background ([\#7041](matrix-org/matrix-react-sdk#7041)). Fixes #17388 and #17388. * Add a high contrast theme (a variant of the light theme) ([\#7036](matrix-org/matrix-react-sdk#7036)). * Improve timeline message for restricted join rule changes ([\#6984](matrix-org/matrix-react-sdk#6984)). Fixes #18980 and #18980. * Improve the appearance of the font size slider ([\#7038](matrix-org/matrix-react-sdk#7038)). * Improve RovingTabIndex & Room List filtering performance ([\#6987](matrix-org/matrix-react-sdk#6987)). Fixes #17864 and #17864. * Remove outdated Spaces restricted rooms warning ([\#6927](matrix-org/matrix-react-sdk#6927)). * Make /msg <message> param optional for more flexibility ([\#7028](matrix-org/matrix-react-sdk#7028)). Fixes #19481 and #19481. * Add decoration to space hierarchy for tiles which have already been j… ([\#6969](matrix-org/matrix-react-sdk#6969)). Fixes #18755 and #18755. * Add insert link button to the format bar ([\#5879](matrix-org/matrix-react-sdk#5879)). Contributed by @SimonBrandner. * Improve visibility of font size chooser ([\#6988](matrix-org/matrix-react-sdk#6988)). * Soften border-radius on selected/hovered messages ([\#6525](matrix-org/matrix-react-sdk#6525)). Fixes #18108. Contributed by @SimonBrandner. * Add a developer mode flag and use it for accessing space timelines ([\#6994](matrix-org/matrix-react-sdk#6994)). Fixes #19416 and #19416. * Position toggle switch more clearly ([\#6914](matrix-org/matrix-react-sdk#6914)). Contributed by @CicadaCinema. * Validate email address in forgot password dialog ([\#6983](matrix-org/matrix-react-sdk#6983)). Fixes #9978 and #9978. Contributed by @psrpinto. * Handle and i18n M_THREEPID_IN_USE during registration ([\#6986](matrix-org/matrix-react-sdk#6986)). Fixes #13767 and #13767. * For space invite previews, use room summary API to get the right member count ([\#6982](matrix-org/matrix-react-sdk#6982)). Fixes #19123 and #19123. * Simplify Space Panel notification badge layout ([\#6977](matrix-org/matrix-react-sdk#6977)). Fixes #18527 and #18527. * Use prettier hsName during 3pid registration where possible ([\#6980](matrix-org/matrix-react-sdk#6980)). Fixes #19162 and #19162. ## 🐛 Bug Fixes * Add a condition to only activate the resizer which belongs to the clicked handle ([\#7055](matrix-org/matrix-react-sdk#7055)). Fixes #19521 and #19521. * Restore composer focus after event edit ([\#7065](matrix-org/matrix-react-sdk#7065)). Fixes #19469 and #19469. * Don't apply message bubble visual style to media messages ([\#7040](matrix-org/matrix-react-sdk#7040)). * Handle no selected screen when screen-sharing ([\#7018](matrix-org/matrix-react-sdk#7018)). Fixes #19460 and #19460. Contributed by @SimonBrandner. * Add history entry before completing emoji ([\#7007](matrix-org/matrix-react-sdk#7007)). Fixes #19177 and #19177. Contributed by @RafaelGoncalves8. * Add padding between controls on edit form in message bubbles ([\#7039](matrix-org/matrix-react-sdk#7039)). * Respect the roomState right container request for the Jitsi widget ([\#7033](matrix-org/matrix-react-sdk#7033)). Fixes #16552 and #16552. * Fix cannot read length of undefined for room upgrades ([\#7037](matrix-org/matrix-react-sdk#7037)). Fixes #19509 and #19509. * Cleanup re-dispatching around timelines and composers ([\#7023](matrix-org/matrix-react-sdk#7023)). Fixes #19491 and #19491. Contributed by @SimonBrandner. * Fix removing a room from a Space and interaction with `m.space.parent` ([\#6944](matrix-org/matrix-react-sdk#6944)). Fixes #19363 and #19363. * Fix recent css regression ([\#7022](matrix-org/matrix-react-sdk#7022)). Fixes #19470 and #19470. Contributed by @CicadaCinema. * Fix ModalManager reRender racing with itself ([\#7027](matrix-org/matrix-react-sdk#7027)). Fixes #19489 and #19489. * Fix fullscreening a call while connecting ([\#7019](matrix-org/matrix-react-sdk#7019)). Fixes #19309 and #19309. Contributed by @SimonBrandner. * Allow scrolling right in reply-quoted code block ([\#7024](matrix-org/matrix-react-sdk#7024)). Fixes #19487 and #19487. Contributed by @SimonBrandner. * Fix dark theme codeblock colors ([\#6384](matrix-org/matrix-react-sdk#6384)). Fixes #17998. Contributed by @SimonBrandner. * Show passphrase input label ([\#6992](matrix-org/matrix-react-sdk#6992)). Fixes #19428 and #19428. Contributed by @RafaelGoncalves8. * Always render disabled settings as disabled ([\#7014](matrix-org/matrix-react-sdk#7014)). * Make "Security Phrase" placeholder look consistent cross-browser ([\#6870](matrix-org/matrix-react-sdk#6870)). Fixes #19006 and #19006. Contributed by @neer17. * Fix direction override characters breaking member event text direction ([\#6999](matrix-org/matrix-react-sdk#6999)). * Remove redundant text in verification dialogs ([\#6993](matrix-org/matrix-react-sdk#6993)). Fixes #19290 and #19290. Contributed by @RafaelGoncalves8. * Fix space panel name overflowing ([\#6995](matrix-org/matrix-react-sdk#6995)). Fixes #19455 and #19455. * Fix conflicting CSS on syntax highlighted blocks ([\#6991](matrix-org/matrix-react-sdk#6991)). Fixes #19445 and #19445.
Fixes element-hq/element-web#19466
Proposed changes
Keeps track of the invites count on the bulk button when it changes instead of fetching it only when entering the Security & Privacy tab to avoid a wrong count after clicking the button.
Before
After
Steps to reproduce
Steps to reproduce from issue:
Signed-off-by: Renan [email protected]
Here's what your changelog entry will look like:
🐛 Bug Fixes
Preview: https://61941b56f813071a10a8ed8f--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.