Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Improve Thread View UI #7063

Merged
merged 6 commits into from
Nov 2, 2021
Merged

Improve Thread View UI #7063

merged 6 commits into from
Nov 2, 2021

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Nov 1, 2021

Fixes element-hq/element-web#19542

  • Keep thread header button highlighted when viewing a thread
  • Implement thread header view UI
  • Implement correct spacing and background for thread view elements
  • Fix timestamp logic on thread view

Screen Shot 2021-11-01 at 16 49 41

Screen Shot 2021-11-01 at 16 51 15


This PR currently has no changelog labels, so will not be included in changelogs.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

Preview: https://618027d021a499c80ba05882--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@germain-gg germain-gg requested a review from a team as a code owner November 1, 2021 16:51
@germain-gg germain-gg changed the title Keep thread header button highlighted when viewing a thread Improve Thread View UI Nov 1, 2021
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, thanks! 😄

}

&__header {
width: calc(100% - 40px);
.mx_ThreadPanel__header {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not used to seeing this __ style in Element Web, but I assume you know what you're doing...

@germain-gg germain-gg merged commit 0bae79d into develop Nov 2, 2021
@germain-gg germain-gg deleted the gsouquet/thread-view branch November 2, 2021 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement high fidelity event tile for thread view
2 participants