Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement high fidelity event tile for thread view #19542

Closed
Tracked by #3
germain-gg opened this issue Oct 28, 2021 · 2 comments · Fixed by matrix-org/matrix-react-sdk#7063
Closed
Tracked by #3

Implement high fidelity event tile for thread view #19542

germain-gg opened this issue Oct 28, 2021 · 2 comments · Fixed by matrix-org/matrix-react-sdk#7063
Assignees
Labels
A-Threads T-Task Tasks for the team like planning

Comments

@germain-gg
Copy link
Contributor

Screen Shot 2021-10-28 at 12 53 59

Design: https://www.figma.com/file/T309ztx0sNyOOK6NKVLHsK/Threads?node-id=1150%3A190531

@germain-gg
Copy link
Contributor Author

Couple of things that would be interesting to hear from @janogarcia

  • Where would the "encrypted" shield should be displayed?
  • Are we stripping the timestamp altogether? I have not found any references to it
  • Should I keep the date delimiters? I could not see that in the designs either

@janogarcia
Copy link

janogarcia commented Oct 28, 2021

Are we stripping the timestamp altogether? I have not found any references to it
Should I keep the date delimiters? I could not see that in the designs either

Same default behavior as in the room timeline: message timestamp shown for the latest message by default and on hover for the rest, date header in timeline for each day, etc.

Where would the "encrypted" shield should be displayed?

Same as in the room timeline. I tried not to make any change to the default behavior of the timeline component, so that we have a consistent experience between both timelines, room and thread timelines.

So, yes, as a general rule, keep everything from the room timeline unless it's clearly conflicting with the Threads UI. And if anything's conflicting and there's no mockup for it, then just let me know. 👍

Thanks for double checking anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants